[PATCH] grep: remove tautological check
- From
David Soria Parra <dsp@php.net>
- Date
- Oct 20, 2012, 17:26 UTC
- Message-ID
- <1350753964-29346-1-git-send-email-dsp@php.net>
The enum grep_header_field is unsigned. Therefore the field part of the grep_pat structure is unsigned and cannot be less then 0. We remove the tautological check for p->field < 0.
Signed-off-by: David Soria Parra <dsp@php.net> --- grep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/grep.c b/grep.c index 4bd1b8b..db177ef 100644 --- a/grep.c +++ b/grep.c @@ -625,7 +625,7 @@ static struct grep_expr *prep_header_patterns(struct grep_opt *opt) for (p = opt->header_list; p; p = p->next) { if (p->token != GREP_PATTERN_HEAD) die("bug: a non-header pattern in grep header list."); - if (p->field < 0 || GREP_HEADER_FIELD_MAX <= p->field) + if (GREP_HEADER_FIELD_MAX <= p->field) die("bug: unknown header field %d", p->field); compile_regexp(p, opt); }
-- 1.8.0.rc3.332.g181c802