git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/5] delete_ref(): Remove the correct reflog when deleting symrefs

From
Johan Herland <johan@herland.net>
Date
Oct 16, 2012, 13:44 UTC
Message-ID
<1350395094-11404-4-git-send-email-johan@herland.net>
In-Reply-To
<1350395094-11404-1-git-send-email-johan@herland.net>

When deleting a symref (e.g. HEAD), we would incorrectly remove the reflog of the dereferenced ref (e.g. .git/logs/refs/heads/master), insted of the symref's reflog (e.g. .git/logs/HEAD).

This patch ensures that we remove the reflog that corresponds to the removed (sym)ref.

Signed-off-by: Johan Herland <johan@herland.net>
---
 refs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/refs.c b/refs.c
index df4fe20..f2508bf 100644
--- a/refs.c
+++ b/refs.c
@@ -1781,7 +1781,7 @@ int delete_ref(const char *refname, const unsigned char *sha1, int delopt)
 	if (!delete_symref)
 		ret |= repack_without_ref(refname);
 
-	unlink_or_warn(git_path("logs/%s", lock->ref_name));
+	unlink_or_warn(git_path("logs/%s", refname));
 	invalidate_ref_cache(NULL);
 	unlock_ref(lock);
 	return ret;
-- 
1.7.12.1.609.g5cd6968
Previous: Johan HerlandNext: Johan Herland
Message 4 of 7 in “Fixing problem with deleting symrefs”
  1. 0/5 Fixing problem with deleting symrefsJohan Herland, Oct 16, 2012
  2. 1/5 t1400-update-ref: Add test verifying bug with symrefs in delete_ref()Johan Herland, Oct 16, 2012
  3. 2/5 delete_ref(): Fix deletion of refs through symbolic refsJohan Herland, Oct 16, 2012
  4. 3/5 delete_ref(): Remove the correct reflog when deleting symrefsJohan Herland, Oct 16, 2012
  5. 4/5 Add tests for using symbolic refs as branch name aliases.Johan Herland, Oct 16, 2012
  6. 5/5 branch -d: Fix failure to remove branch aliases (symrefs)Johan Herland, Oct 16, 2012
  7. Junio C HamanoOct 16, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.