git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Rebase doesn't restore branch pointer back on out of memory

From
Andrew Wong <andrew.kw.w@gmail.com>
Date
Oct 11, 2012, 03:54 UTC
Message-ID
<1349927643-7195-1-git-send-email-andrew.kw.w@gmail.com>
In-Reply-To
<7vtxu4io7o.fsf@alter.siamese.dyndns.org>
For the 'format-patch' part, originally I was going to do something like:
	git format-patch ... || {
		...
	}

But later I thought it's better to use a consistent style as the following 'am' part.

For the 'am' part, if we kept the following line at the end of the if-block:
	fi && move_to_original_branch
then, before exiting the if-block, we would have to do something like:
	test 0 != $ret && false

which seems a bit ugly to me. So I removed the use of '&&', and rearrange the 'write_basic_state' and 'move_to_original_branch' to make the logic flow a bit better and easier to read.

Andrew Wong (1):
  rebase: Handle cases where format-patch fails
 git-rebase--am.sh | 51 +++++++++++++++++++++++++++++++++++++++++++++------
 1 file changed, 45 insertions(+), 6 deletions(-)
-- 
1.8.0.rc0.19.gc58a63a.dirty
Previous: Junio C HamanoNext: Andrew Wong
Message 14 of 17 in “Rebase doesn't restore branch pointer back on out of memory”
  1. Alexander KostikovOct 3, 2012
  2. Andrew WongOct 3, 2012
  3. Andrew WongOct 4, 2012
  4. Alexander KostikovOct 4, 2012
  5. Alexander KostikovOct 4, 2012
  6. Andrew WongOct 4, 2012
  7. Alexander KostikovOct 4, 2012
  8. Andrew WongOct 5, 2012
  9. [RFC] rebase: Handle cases where format-patch failsAndrew Wong, Oct 5, 2012
  10. Junio C HamanoOct 5, 2012
  11. Andrew WongOct 8, 2012
  12. [RFC] rebase: Handle cases where format-patch failsAndrew Wong, Oct 8, 2012
  13. Junio C HamanoOct 8, 2012
  14. Andrew WongOct 11, 2012
  15. rebase: Handle cases where format-patch failsAndrew Wong, Oct 11, 2012
  16. Alexander KostikovOct 19, 2012
  17. Junio C HamanoOct 19, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.