git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] mergetools/p4merge: Handle "/dev/null"

From
David Aguilar <davvid@gmail.com>
Date
Oct 11, 2012, 03:22 UTC
Message-ID
<1349925756-87801-1-git-send-email-davvid@gmail.com>

p4merge does not properly handle the case where "/dev/null" is passed as a filename.

Workaround it by creating a temporary file for this purpose.
Reported-by: Jeremy Morton <admin@game-point.net>
Signed-off-by: David Aguilar <davvid@gmail.com>
---
Jeremy, can you test this?
 mergetools/p4merge | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
diff --git a/mergetools/p4merge b/mergetools/p4merge
index 1a45c1b..295361a 100644
--- a/mergetools/p4merge
+++ b/mergetools/p4merge
@@ -1,5 +1,30 @@
 diff_cmd () {
+	# p4merge does not like /dev/null
+	rm_local=
+	rm_remote=
+	if test "/dev/null" = "$LOCAL"
+	then
+		LOCAL="./p4merge-dev-null.LOCAL.$$"
+		>"$LOCAL"
+		rm_local=true
+	fi
+	if test "/dev/null" = "$REMOTE"
+	then
+		REMOTE="./p4merge-dev-null.REMOTE.$$"
+		>"$REMOTE"
+		rm_remote=true
+	fi
+
 	"$merge_tool_path" "$LOCAL" "$REMOTE"
+
+	if test -n "$rm_local"
+	then
+		rm -f "$LOCAL"
+	fi
+	if test -n "$rm_remote"
+	then
+		rm -f "$REMOTE"
+	fi
 }
 
 merge_cmd () {
-- 
1.8.0.rc1
Next: Jeremy Morton
Message 1 of 3 in “mergetools/p4merge: Handle "/dev/null"”
  1. mergetools/p4merge: Handle "/dev/null"David Aguilar, Oct 11, 2012
  2. Jeremy MortonOct 27, 2012
  3. David AguilarDec 20, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.