git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] configure.ac: Add missing comma to CC_LD_DYNPATH

From
Øyvind A. Holm <sunny@sunbase.org>
Date
Oct 9, 2012, 14:26 UTC
Message-ID
<1349792771-7936-1-git-send-email-sunny@sunbase.org>
From: "Øyvind A. Holm" <sunny@sunbase.org>

40bfbde ("build: don't duplicate substitution of make variables", 2012-09-11) breaks make by removing a necessary comma at the end of "CC_LD_DYNPATH=-rpath" in line 414.

When executing "./configure --with-zlib=PATH", this resulted in
      [...]
      CC xdiff/xhistogram.o
      AR xdiff/lib.a
      LINK git-credential-store
  /usr/bin/ld: bad -rpath option
  collect2: ld returned 1 exit status
  make: *** [git-credential-store] Error 1
  $
during make.
Signed-off-by: Øyvind A. Holm <sunny@sunbase.org>
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index da1f41f..c85888c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -411,7 +411,7 @@ else
       LDFLAGS="${SAVE_LDFLAGS}"
    ])
    if test "$git_cv_ld_wl_rpath" = "yes"; then
-      CC_LD_DYNPATH=-Wl,-rpath
+      CC_LD_DYNPATH=-Wl,-rpath,
    else
       AC_CACHE_CHECK([if linker supports -rpath], git_cv_ld_rpath, [
          SAVE_LDFLAGS="${LDFLAGS}"
-- 
1.8.0.rc0.18.gf84667d
Message 1 of 1 in “configure.ac: Add missing comma to CC_LD_DYNPATH”
  1. configure.ac: Add missing comma to CC_LD_DYNPATHØyvind A. Holm, Oct 9, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.