[PATCH 07/10] wildmatch: fix case-insensitive matching
- From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
- Date
- Oct 5, 2012, 04:41 UTC
- Message-ID
- <1349412069-627-8-git-send-email-pclouds@gmail.com>
- In-Reply-To
- <1349412069-627-1-git-send-email-pclouds@gmail.com>
dowild() does case insensitive matching by lower-casing the text. That means lower case letters in patterns imply case-insensitive matching, but upper case means exact matching.
We do not want that subtlety. Lower case pattern too so iwildmatch() always does what we expect it to do.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> --- wildmatch.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/wildmatch.c b/wildmatch.c index e824eb2..c7f7f9f 100644 --- a/wildmatch.c +++ b/wildmatch.c @@ -81,6 +81,8 @@ static int dowild(const uchar *p, const uchar *text, } if (force_lower_case && ISUPPER(t_ch)) t_ch = tolower(t_ch); + if (force_lower_case && ISUPPER(p_ch)) + p_ch = tolower(p_ch); switch (p_ch) { case '\\': /* Literal match with following character. Note that the test
-- 1.7.12.1.405.gb727dc9