Re: [PATCH 3/4] log --count: added test

From: Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr>
Date: Jul 2, 2015, 09:09 UTC
Message-ID: <134930107.140053.1435828168932.JavaMail.zimbra@ensimag.grenoble-inp.fr>
In-Reply-To: <1435815536-30611-3-git-send-email-lawrencesiebert@gmail.com>

Hi Lawrence,

Lawrence Siebert <lawrencesiebert@gmail.com> writes:

> +test_expect_success 'log --count' '
> +        git log --count HEAD > actual &&
> +        git        rev-list --count HEAD > expect &&

Why the huge space here between 'git' and 'rev-list'? Also no space after the redirection ('>'), it should be '>actual' and '>expect'.

> +        test_cmp expect actual
> +'        
> +

In the mail I see some trailing whitespace after the last two lines. I can't apply it myself before some time, so I can't see if 'git am' warns me about trailing whitespace. You can use 'git log --check' to see the trailing whitespace in your commits. I'll look if I see some trailing whitespace in your other parts of the patch but I might miss some.

Rémi