[PATCH] gitk: Rename 'tagcontents' to 'cached_tagcontent'
- From
David Aguilar <davvid@gmail.com>
- Date
- Sep 8, 2012, 19:53 UTC
- Message-ID
- <1347133996-70908-1-git-send-email-davvid@gmail.com>
- In-Reply-To
- <1347130993-69863-1-git-send-email-davvid@gmail.com>
Name the 'tagcontents' variable similarly to the rest of the variables cleared in the changedrefs() function.
This makes the naming consistent and provides a hint that it should be cleared when reloading gitk's cache.
Suggested-by: Junio C Hamano <gitster@pobox.com> Signed-off-by: David Aguilar <davvid@gmail.com> ---
Follow-up to 'gitk: Teach "Reread references" to reload tags'
gitk | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/gitk b/gitk index a124822..6f24f53 100755 --- a/gitk +++ b/gitk @@ -10599,7 +10599,7 @@ proc movedhead {hid head} { } proc changedrefs {} { - global cached_dheads cached_dtags cached_atags tagcontents + global cached_dheads cached_dtags cached_atags cached_tagcontent global arctags archeads arcnos arcout idheads idtags foreach id [concat [array names idheads] [array names idtags]] { @@ -10611,7 +10611,7 @@ proc changedrefs {} { } } } - catch {unset tagcontents} + catch {unset cached_tagcontent} catch {unset cached_dtags} catch {unset cached_atags} catch {unset cached_dheads} @@ -10664,7 +10664,7 @@ proc listrefs {id} { } proc showtag {tag isnew} { - global ctext tagcontents tagids linknum tagobjid + global ctext cached_tagcontent tagids linknum tagobjid if {$isnew} { addtohistory [list showtag $tag 0] savectextpos @@ -10673,13 +10673,13 @@ proc showtag {tag isnew} { clear_ctext settabs 0 set linknum 0 - if {![info exists tagcontents($tag)]} { + if {![info exists cached_tagcontent($tag)]} { catch { - set tagcontents($tag) [exec git cat-file tag $tag] + set cached_tagcontent($tag) [exec git cat-file tag $tag] } } - if {[info exists tagcontents($tag)]} { - set text $tagcontents($tag) + if {[info exists cached_tagcontent($tag)]} { + set text $cached_tagcontent($tag) } else { set text "[mc "Tag"]: $tag\n[mc "Id"]: $tagids($tag)" }
-- 1.7.7.2.448.gee6df