[PATCH 5/7] t0000: verify that real_path() works correctly with absolute paths
- From
mhagger@alum.mit.edu <mhagger@alum.mit.edu>
- Date
- Sep 4, 2012, 08:14 UTC
- Message-ID
- <1346746470-23127-6-git-send-email-mhagger@alum.mit.edu>
- In-Reply-To
- <1346746470-23127-1-git-send-email-mhagger@alum.mit.edu>
From: Michael Haggerty <mhagger@alum.mit.edu>
There is currently a bug: if passed an absolute top-level path that doesn't exist (e.g., "/foo") it incorrectly interprets the path as a relative path (e.g., returns "$(pwd)/foo"). So mark the test as failing.
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> --- t/t0000-basic.sh | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh index 1a51634..ad002ee 100755 --- a/t/t0000-basic.sh +++ b/t/t0000-basic.sh @@ -458,7 +458,17 @@ test_expect_success 'real path rejects the empty string' ' test_must_fail test-path-utils real_path "" ' -test_expect_success SYMLINKS 'real path works as expected' ' +test_expect_failure 'real path works on absolute paths' ' + nopath="hopefully-absent-path" && + test "/" = "$(test-path-utils real_path "/")" && + test "/$nopath" = "$(test-path-utils real_path "/$nopath")" && + # Find an existing top-level directory for the remaining tests: + d=$(pwd -P | sed -e "s|^\(/[^/]*\)/.*|\1|") && + test "$d" = "$(test-path-utils real_path "$d")" && + test "$d/$nopath" = "$(test-path-utils real_path "$d/$nopath")" +' + +test_expect_success SYMLINKS 'real path works on symlinks' ' mkdir first && ln -s ../.git first/.git && mkdir second &&
-- 1.7.11.3