git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 1/6] name-rev: lose unnecessary typedef

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 30, 2012, 03:50 UTC
Message-ID
<1346298629-13730-2-git-send-email-gitster@pobox.com>
In-Reply-To
<1346298629-13730-1-git-send-email-gitster@pobox.com>

Just spell it "struct rev_name"; it makes it more clear what is going on.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 builtin/name-rev.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/builtin/name-rev.c b/builtin/name-rev.c
index 1b37458..8af2cfa 100644
--- a/builtin/name-rev.c
+++ b/builtin/name-rev.c
@@ -7,11 +7,11 @@
 
 #define CUTOFF_DATE_SLOP 86400 /* one day */
 
-typedef struct rev_name {
+struct rev_name {
 	const char *tip_name;
 	int generation;
 	int distance;
-} rev_name;
+};
 
 static long cutoff = LONG_MAX;
 
@@ -43,7 +43,7 @@ static void name_rev(struct commit *commit,
 	}
 
 	if (name == NULL) {
-		name = xmalloc(sizeof(rev_name));
+		name = xmalloc(sizeof(struct rev_name));
 		commit->util = name;
 		goto copy_data;
 	} else if (name->distance > distance) {
-- 
1.7.12.286.g9df01f7
Previous: Junio C HamanoNext: Junio C Hamano
Message 2 of 8 in “describe --contains / name-rev --weight”
  1. 0/6 describe --contains / name-rev --weightJunio C Hamano, Aug 30, 2012
  2. 1/6 name-rev: lose unnecessary typedefJunio C Hamano, Aug 30, 2012
  3. 2/6 name_rev: clarify the logic to assign a new tip-name to a commitJunio C Hamano, Aug 30, 2012
  4. 3/6 name-rev: --weight optionJunio C Hamano, Aug 30, 2012
  5. 5/6 name-rev --weight: trivial optimizationJunio C Hamano, Sep 4, 2012
  6. 4/6 name-rev --weight: cache the computed weight in notesJunio C Hamano, Aug 30, 2012
  7. 5/6 name-rev --weight: tests and documentationJunio C Hamano, Aug 30, 2012
  8. 6/6 describe --contains: use "name-rev --weight"Junio C Hamano, Aug 30, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.