git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 6/8] Move Git::IndexInfo into its own file.

From
Michael G. Schwern <schwern@pobox.com>
Date
Jul 27, 2012, 00:26 UTC
Message-ID
<1343348767-86446-7-git-send-email-schwern@pobox.com>
In-Reply-To
<1343348767-86446-1-git-send-email-schwern@pobox.com>
From: "Michael G. Schwern" <schwern@pobox.com>
Straight cut & paste.  Didn't require any fixing.
---
 git-svn.perl            | 32 --------------------------------
 perl/Git/IndexInfo.pm   | 33 +++++++++++++++++++++++++++++++++
 perl/Git/SVN/Fetcher.pm |  1 +
 perl/Makefile           |  1 +
 t/Git-SVN/00compile.t   |  3 ++-
 5 files changed, 37 insertions(+), 33 deletions(-)
 create mode 100644 perl/Git/IndexInfo.pm
diff --git a/git-svn.perl b/git-svn.perl
index fc49ad6..0856a77 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -2041,38 +2041,6 @@ sub gc_directory {
 }
 
 
-package Git::IndexInfo;
-use strict;
-use warnings;
-use Git qw/command_input_pipe command_close_pipe/;
-
-sub new {
-	my ($class) = @_;
-	my ($gui, $ctx) = command_input_pipe(qw/update-index -z --index-info/);
-	bless { gui => $gui, ctx => $ctx, nr => 0}, $class;
-}
-
-sub remove {
-	my ($self, $path) = @_;
-	if (print { $self->{gui} } '0 ', 0 x 40, "\t", $path, "\0") {
-		return ++$self->{nr};
-	}
-	undef;
-}
-
-sub update {
-	my ($self, $mode, $hash, $path) = @_;
-	if (print { $self->{gui} } $mode, ' ', $hash, "\t", $path, "\0") {
-		return ++$self->{nr};
-	}
-	undef;
-}
-
-sub DESTROY {
-	my ($self) = @_;
-	command_close_pipe($self->{gui}, $self->{ctx});
-}
-
 package Git::SVN::GlobSpec;
 use strict;
 use warnings;
diff --git a/perl/Git/IndexInfo.pm b/perl/Git/IndexInfo.pm
new file mode 100644
index 0000000..a43108c
--- /dev/null
+++ b/perl/Git/IndexInfo.pm
@@ -0,0 +1,33 @@
+package Git::IndexInfo;
+use strict;
+use warnings;
+use Git qw/command_input_pipe command_close_pipe/;
+
+sub new {
+	my ($class) = @_;
+	my ($gui, $ctx) = command_input_pipe(qw/update-index -z --index-info/);
+	bless { gui => $gui, ctx => $ctx, nr => 0}, $class;
+}
+
+sub remove {
+	my ($self, $path) = @_;
+	if (print { $self->{gui} } '0 ', 0 x 40, "\t", $path, "\0") {
+		return ++$self->{nr};
+	}
+	undef;
+}
+
+sub update {
+	my ($self, $mode, $hash, $path) = @_;
+	if (print { $self->{gui} } $mode, ' ', $hash, "\t", $path, "\0") {
+		return ++$self->{nr};
+	}
+	undef;
+}
+
+sub DESTROY {
+	my ($self) = @_;
+	command_close_pipe($self->{gui}, $self->{ctx});
+}
+
+1;
diff --git a/perl/Git/SVN/Fetcher.pm b/perl/Git/SVN/Fetcher.pm
index ef8e9ed..76fae9b 100644
--- a/perl/Git/SVN/Fetcher.pm
+++ b/perl/Git/SVN/Fetcher.pm
@@ -57,6 +57,7 @@ sub new {
 	$self->{file_prop} = {};
 	$self->{absent_dir} = {};
 	$self->{absent_file} = {};
+	require Git::IndexInfo;
 	$self->{gii} = $git_svn->tmp_index_do(sub { Git::IndexInfo->new });
 	$self->{pathnameencoding} = Git::config('svn.pathnameencoding');
 	$self;
diff --git a/perl/Makefile b/perl/Makefile
index ff83848..2428e59 100644
--- a/perl/Makefile
+++ b/perl/Makefile
@@ -26,6 +26,7 @@ instdir_SQ = $(subst ','\'',$(prefix)/lib)
 
 modules += Git
 modules += Git/I18N
+modules += Git/IndexInfo
 modules += Git/SVN
 modules += Git/SVN/Memoize/YAML
 modules += Git/SVN/Fetcher
diff --git a/t/Git-SVN/00compile.t b/t/Git-SVN/00compile.t
index 1307b65..5419438 100644
--- a/t/Git-SVN/00compile.t
+++ b/t/Git-SVN/00compile.t
@@ -3,10 +3,11 @@
 use strict;
 use warnings;
 
-use Test::More tests => 5;
+use Test::More tests => 6;
 
 require_ok 'Git::SVN';
 require_ok 'Git::SVN::Utils';
 require_ok 'Git::SVN::Ra';
 require_ok 'Git::SVN::Log';
 require_ok 'Git::SVN::Migration';
+require_ok 'Git::IndexInfo';
-- 
1.7.11.1
Previous: Michael G. SchwernNext: Michael G. Schwern
Message 7 of 16 in “Extract remaining classes from git-svn”
  1. Michael G. SchwernJul 27, 2012
  2. 1/8 Prepare Git::SVN::Log for extraction from git-svn.Michael G. Schwern, Jul 27, 2012
  3. 2/8 Extract Git::SVN::Log from git-svn.Michael G. Schwern, Jul 27, 2012
  4. 3/8 Prepare Git::SVN::Migration for extraction from git-svn.Michael G. Schwern, Jul 27, 2012
  5. 4/8 Extract Git::SVN::Migration from git-svn.Michael G. Schwern, Jul 27, 2012
  6. 5/8 Load all the modules in one place and before running code.Michael G. Schwern, Jul 27, 2012
  7. 6/8 Move Git::IndexInfo into its own file.Michael G. Schwern, Jul 27, 2012
  8. 7/8 Extract Git::SVN::GlobSpec from git-svn.Michael G. Schwern, Jul 27, 2012
  9. 8/8 Fix indents to match style.Michael G. Schwern, Jul 27, 2012
  10. Michael G SchwernJul 27, 2012
  11. Erik Faye-LundJul 27, 2012
  12. Michael G SchwernJul 27, 2012
  13. Eric WongJul 28, 2012
  14. Junio C HamanoJul 28, 2012
  15. Eric WongJul 28, 2012
  16. Junio C HamanoJul 28, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.