git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2] difftool: only copy back files modified during directory diff

From
David Aguilar <davvid@gmail.com>
Date
Jul 19, 2012, 08:27 UTC
Message-ID
<1342686429-87847-1-git-send-email-davvid@gmail.com>
In-Reply-To
<CAJDDKr4Q+nQapO0aAQmmpj_guR=_tXwareWsn020BckZR5V+uA@mail.gmail.com>
From: Tim Henigan <tim.henigan@gmail.com>

When 'difftool --dir-diff' is used to compare working tree files, it always copies files from the tmp dir back to the working tree when the diff tool is closed, even if the files were not modified by the diff tool.

This causes the file timestamp to change. Files should only be copied from the tmp dir back to the working copy if they were actually modified.

Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
Signed-off-by: David Aguilar <davvid@gmail.com>
---
Perhaps something like this...
 git-difftool.perl | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/git-difftool.perl b/git-difftool.perl
index ae1e052..c079854 100755
--- a/git-difftool.perl
+++ b/git-difftool.perl
@@ -15,6 +15,7 @@ use strict;
 use warnings;
 use File::Basename qw(dirname);
 use File::Copy;
+use File::Compare;
 use File::Find;
 use File::stat;
 use File::Path qw(mkpath);
@@ -336,8 +337,10 @@ if (defined($dirdiff)) {
 	# files were modified during the diff, then the changes
 	# should be copied back to the working tree
 	for my $file (@working_tree) {
-		copy("$b/$file", "$workdir/$file") or die $!;
-		chmod(stat("$b/$file")->mode, "$workdir/$file") or die $!;
+		if (-e "$b/$file" && compare("$b/$file", "$workdir/$file")) {
+			copy("$b/$file", "$workdir/$file") or die $!;
+			chmod(stat("$b/$file")->mode, "$workdir/$file") or die $!;
+		}
 	}
 } else {
 	if (defined($prompt)) {
-- 
1.7.11.2.250.g00b4b9a
Previous: David AguilarNext: Junio C Hamano
Message 6 of 8 in “difftool: only copy back files modified during directory diff”
  1. 1/2 difftool: only copy back files modified during directory diffTim Henigan, Jun 28, 2012
  2. 2/2 difftool: handle uninitialized variable on empty diffTim Henigan, Jun 28, 2012
  3. Junio C HamanoJun 28, 2012
  4. Junio C HamanoJun 28, 2012
  5. David AguilarJul 19, 2012
  6. difftool: only copy back files modified during directory diffDavid Aguilar, Jul 19, 2012
  7. Junio C HamanoJul 19, 2012
  8. David AguilarJul 21, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.