git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 0/3] Introduction of a ce_namelen field

From
Thomas Gummerer <t.gummerer@gmail.com>
Date
Jul 11, 2012, 09:22 UTC
Message-ID
<1341998558-8502-1-git-send-email-t.gummerer@gmail.com>
In-Reply-To
<7vy5mtlebz.fsf@alter.siamese.dyndns.org>
Thanks to Junio for reviewing v2 of this patch series.

The speedup coming from introducing the field exists, but is minimal, here are the times for 1000 runs of git ls-files on the Webkit index, first without the ce_namelen field, and then with the ce_namelen field. $ time ./test.sh

real 4m40.895s user 3m39.642s sys 0m40.159s

$ time ./test.sh

real 4m34.872s user 3m37.176s sys 0m40.401s

1/3 is a bugfix for very long files which share at least 4096 characters in their filename. It also includes a test, tough I'm not sure I have put it in the right place.

The other two patches are rerolls from v2 of this series.

[PATCH v3 1/3] read-cache.c: Handle long filenames correctly [PATCH v3 2/3] Strip namelen out of ce_flags into a ce_namelen field [PATCH v3 3/3] Replace strlen() with ce_namelen()

builtin/apply.c | 3 ++- builtin/blame.c | 3 ++- builtin/checkout.c | 3 ++- builtin/update-index.c | 9 ++++++--- cache.h | 19 ++++++------------- read-cache.c | 62 +++++++++++++++++++++++++++++++++++++++----------------------- t/t0007-long-filenames.sh | 62 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ tree.c | 7 ++++--- unpack-trees.c | 5 +++-- 9 files changed, 126 insertions(+), 47 deletions(-)

Previous: Junio C HamanoNext: Thomas Gummerer
Message 9 of 18 in “Replace ce_namelen() with a ce_namelen field”
  1. Replace ce_namelen() with a ce_namelen fieldThomas Gummerer, Jul 4, 2012
  2. Thomas RastJul 4, 2012
  3. Nguyen Thai Ngoc DuyJul 4, 2012
  4. Nguyen Thai Ngoc DuyJul 4, 2012
  5. Junio C HamanoJul 4, 2012
  6. Introduction of a ce_namelen fieldThomas Gummerer, Jul 6, 2012
  7. 1/2 Strip namelen out of ce_flags into a ce_namelen fieldThomas Gummerer, Jul 6, 2012
  8. Junio C HamanoJul 9, 2012
  9. 0/3 Introduction of a ce_namelen fieldThomas Gummerer, Jul 11, 2012
  10. 1/3 read-cache.c: Handle long filenames correctlyThomas Gummerer, Jul 11, 2012
  11. Nguyen Thai Ngoc DuyJul 11, 2012
  12. Junio C HamanoJul 11, 2012
  13. 2/3 Strip namelen out of ce_flags into a ce_namelen fieldThomas Gummerer, Jul 11, 2012
  14. 3/3 Replace strlen() with ce_namelen()Thomas Gummerer, Jul 11, 2012
  15. Junio C HamanoJul 11, 2012
  16. Junio C HamanoJul 11, 2012
  17. 2/2 Replace strlen() with ce_namelen()Thomas Gummerer, Jul 6, 2012
  18. Junio C HamanoJul 9, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.