git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v4 12/19] apply: fall back on three-way merge

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 10, 2012, 07:04 UTC
Message-ID
<1341903852-4815-13-git-send-email-gitster@pobox.com>
In-Reply-To
<1341903852-4815-1-git-send-email-gitster@pobox.com>

Grab the preimage blob the patch claims to be based on out of the object store, apply the patch, and then call three-way-merge function. This step still does not plug the actual three-way merge logic yet, but we are getting there.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 builtin/apply.c | 46 +++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 45 insertions(+), 1 deletion(-)
diff --git a/builtin/apply.c b/builtin/apply.c
index 51b695b..5a7201f 100644
--- a/builtin/apply.c
+++ b/builtin/apply.c
@@ -3140,10 +3140,54 @@ static int load_preimage(struct image *image,
 	return 0;
 }
 
+static int three_way_merge(struct image *image,
+			   char *path,
+			   const unsigned char *base,
+			   const unsigned char *ours,
+			   const unsigned char *theirs)
+{
+	return -1; /* for now */
+}
+
 static int try_threeway(struct image *image, struct patch *patch,
 			struct stat *st, struct cache_entry *ce)
 {
-	return -1; /* for now */
+	unsigned char pre_sha1[20], post_sha1[20], our_sha1[20];
+	struct strbuf buf = STRBUF_INIT;
+	size_t len;
+	char *img;
+	struct image tmp_image;
+
+	/* No point falling back to 3-way merge in these cases */
+	if (patch->is_new || patch->is_delete ||
+	    S_ISGITLINK(patch->old_mode) || S_ISGITLINK(patch->new_mode))
+		return -1;
+
+	/* Preimage the patch was prepared for */
+	if (get_sha1(patch->old_sha1_prefix, pre_sha1) ||
+	    read_blob_object(&buf, pre_sha1, patch->old_mode))
+		return error("repository lacks the necessary blob to fall back on 3-way merge.");
+	img = strbuf_detach(&buf, &len);
+	prepare_image(&tmp_image, img, len, 1);
+	/* Apply the patch to get the post image */
+	if (apply_fragments(&tmp_image, patch) < 0) {
+		clear_image(&tmp_image);
+		return -1;
+	}
+	/* post_sha1[] is theirs */
+	write_sha1_file(tmp_image.buf, tmp_image.len, blob_type, post_sha1);
+	clear_image(&tmp_image);
+
+	/* our_sha1[] is ours */
+	if (load_preimage(&tmp_image, patch, st, ce))
+		return error("cannot read the current contents of '%s'",
+			     patch->old_name);
+	write_sha1_file(tmp_image.buf, tmp_image.len, blob_type, our_sha1);
+	clear_image(&tmp_image);
+
+	/* in-core three-way merge between post and our using pre as base */
+	return three_way_merge(image,
+			       patch->new_name, pre_sha1, our_sha1, post_sha1);
 }
 
 static int apply_data(struct patch *patch, struct stat *st, struct cache_entry *ce)
-- 
1.7.11.1.294.g68a9409
Previous: Junio C HamanoNext: Junio C Hamano
Message 13 of 20 in “"git apply --3way"”
  1. 00/19 "git apply --3way"Junio C Hamano, Jul 10, 2012
  2. 01/19 apply: fix an incomplete comment in check_patch()Junio C Hamano, Jul 10, 2012
  3. 02/19 apply: a bit more comments on PATH_TO_BE_DELETEDJunio C Hamano, Jul 10, 2012
  4. 03/19 apply: clear_image() clears things a bit moreJunio C Hamano, Jul 10, 2012
  5. 04/19 apply: refactor read_file_or_gitlink()Junio C Hamano, Jul 10, 2012
  6. 05/19 apply: factor out checkout_target() helper functionJunio C Hamano, Jul 10, 2012
  7. 06/19 apply: split load_preimage() helper function outJunio C Hamano, Jul 10, 2012
  8. 07/19 apply: refactor "previous patch" logicJunio C Hamano, Jul 10, 2012
  9. 08/19 apply: further split load_preimage()Junio C Hamano, Jul 10, 2012
  10. 09/19 apply: move check_to_create_blob() closer to its sole callerJunio C Hamano, Jul 10, 2012
  11. 10/19 apply: move "already exists" logic to check_to_create()Junio C Hamano, Jul 10, 2012
  12. 11/19 apply: accept -3/--3way command line optionJunio C Hamano, Jul 10, 2012
  13. 12/19 apply: fall back on three-way mergeJunio C Hamano, Jul 10, 2012
  14. 13/19 apply: plug the three-way merge logic inJunio C Hamano, Jul 10, 2012
  15. 14/19 apply: move verify_index_match() higherJunio C Hamano, Jul 10, 2012
  16. 15/19 apply: --3way with add/add conflictJunio C Hamano, Jul 10, 2012
  17. 16/19 apply: register conflicted stages to the indexJunio C Hamano, Jul 10, 2012
  18. 17/19 apply: allow rerere() to work on --3way resultsJunio C Hamano, Jul 10, 2012
  19. 18/19 apply: document --3way optionJunio C Hamano, Jul 10, 2012
  20. 19/19 apply: tests for the --3way optionJunio C Hamano, Jul 10, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.