git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv2 07/10] git p4 test: copy source indeterminate

From
PWPete Wyckoff <pw@padd.com>
Date
Jun 27, 2012, 12:01 UTC
Message-ID
<1340798463-14499-8-git-send-email-pw@padd.com>
In-Reply-To
<1340798463-14499-1-git-send-email-pw@padd.com>

Msysgit testing showed that the source file found by copy detection is indeterminate when there are multiple sources to choose from. This appears to be valid. Adjust the test so that it passes if it finds any of the potential copy sources.

Signed-off-by: Pete Wyckoff <pw@padd.com>
---
 t/t9800-git-p4-basic.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t9800-git-p4-basic.sh b/t/t9800-git-p4-basic.sh
index 84676a1..60c1f57 100755
--- a/t/t9800-git-p4-basic.sh
+++ b/t/t9800-git-p4-basic.sh
@@ -547,7 +547,7 @@ test_expect_success 'detect copies' '
 		level=$(git diff-tree -r -C --find-copies-harder HEAD | sed 1d | cut -f1 | cut -d" " -f5 | sed "s/C0*//") &&
 		test -n "$level" && test "$level" -gt 0 && test "$level" -lt 98 &&
 		src=$(git diff-tree -r -C --find-copies-harder HEAD | sed 1d | cut -f2) &&
-		test "$src" = file10 &&
+		test "$src" = file10 -o "$src" = file11 &&
 		git config git-p4.detectCopies $(($level + 2)) &&
 		git p4 submit &&
 		p4 filelog //depot/file12 &&
@@ -561,7 +561,7 @@ test_expect_success 'detect copies' '
 		level=$(git diff-tree -r -C --find-copies-harder HEAD | sed 1d | cut -f1 | cut -d" " -f5 | sed "s/C0*//") &&
 		test -n "$level" && test "$level" -gt 2 && test "$level" -lt 100 &&
 		src=$(git diff-tree -r -C --find-copies-harder HEAD | sed 1d | cut -f2) &&
-		test "$src" = file10 &&
+		test "$src" = file10 -o "$src" = file11 -o "$src" = file12 &&
 		git config git-p4.detectCopies $(($level - 2)) &&
 		git p4 submit &&
 		p4 filelog //depot/file13 &&
-- 
1.7.11.1.69.gd505fd2
Previous: Pete WyckoffNext: Pete Wyckoff
Message 11 of 14 in “[PATCHv2 00/10] git p4 test fixes”
  1. Pete WyckoffJun 27, 2012
  2. 01/10 git p4 test: wait longer for p4d to start and test its pidPete Wyckoff, Jun 27, 2012
  3. Junio C HamanoJun 27, 2012
  4. 01/10 git p4 test: wait longer for p4d to start and test its pidPete Wyckoff, Jun 28, 2012
  5. Junio C HamanoJun 28, 2012
  6. 02/10 git p4 test: use real_path to resolve p4 client symlinksPete Wyckoff, Jun 27, 2012
  7. 03/10 git p4 test: simplify quoting involving TRASH_DIRECTORYPete Wyckoff, Jun 27, 2012
  8. 04/10 git p4 test: never create default test repoPete Wyckoff, Jun 27, 2012
  9. 05/10 git p4 test: rename some "git-p4 command" stringsPete Wyckoff, Jun 27, 2012
  10. 06/10 git p4 test: check for error message in failed testPete Wyckoff, Jun 27, 2012
  11. 07/10 git p4 test: copy source indeterminatePete Wyckoff, Jun 27, 2012
  12. 08/10 git p4 test: cleanup_git should make a new $gitPete Wyckoff, Jun 27, 2012
  13. 09/10 git p4 test: split up big t9800 testPete Wyckoff, Jun 27, 2012
  14. 10/10 git p4 test: fix badp4dir testPete Wyckoff, Jun 27, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.