git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/5] rebase: don't source git-sh-setup twice

From
Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
Date
Jun 26, 2012, 14:51 UTC
Message-ID
<1340722318-24392-2-git-send-email-martin.von.zweigbergk@gmail.com>
In-Reply-To
<1340722318-24392-1-git-send-email-martin.von.zweigbergk@gmail.com>
The git-sh-setup script is already sourced in git-rebase.sh before
calling into git-rebase--(am|interactive|merge).sh. There are no other
callers of these scripts. It is therefore unnecessary to source
git-sh-setup again in them.
---
 git-rebase--am.sh          |    2 --
 git-rebase--interactive.sh |    4 +---
 git-rebase--merge.sh       |    2 --
 3 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/git-rebase--am.sh b/git-rebase--am.sh
index 04d8941..392ebc9 100644
--- a/git-rebase--am.sh
+++ b/git-rebase--am.sh
@@ -3,8 +3,6 @@
 # Copyright (c) 2010 Junio C Hamano.
 #
 
-. git-sh-setup
-
 case "$action" in
 continue)
 	git am --resolved --resolvemsg="$resolvemsg" &&
diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
index 0c19b7c..a5b018d 100644
--- a/git-rebase--interactive.sh
+++ b/git-rebase--interactive.sh
@@ -9,9 +9,7 @@
 #
 # The original idea comes from Eric W. Biederman, in
 # http://article.gmane.org/gmane.comp.version-control.git/22407
-
-. git-sh-setup
-
+#
 # The file containing rebase commands, comments, and empty lines.
 # This file is created by "git rebase -i" then edited by the user.  As
 # the lines are processed, they are removed from the front of this
diff --git a/git-rebase--merge.sh b/git-rebase--merge.sh
index dc59907..b10f2cf 100644
--- a/git-rebase--merge.sh
+++ b/git-rebase--merge.sh
@@ -3,8 +3,6 @@
 # Copyright (c) 2010 Junio C Hamano.
 #
 
-. git-sh-setup
-
 prec=4
 
 read_state () {
-- 
1.7.9.3.327.g2980b
Previous: Martin von ZweigbergkNext: Martin von Zweigbergk
Message 2 of 8 in “rebase: calculate patches in upstream correctly”
  1. 0/5 rebase: calculate patches in upstream correctlyMartin von Zweigbergk, Jun 26, 2012
  2. 1/5 rebase: don't source git-sh-setup twiceMartin von Zweigbergk, Jun 26, 2012
  3. 2/5 rebase --root: print usage on too many argsMartin von Zweigbergk, Jun 26, 2012
  4. 3/5 am --rebasing: get patch body from commit, not from mailboxMartin von Zweigbergk, Jun 26, 2012
  5. 4/5 am: don't call mailinfo if $rebasingMartin von Zweigbergk, Jun 26, 2012
  6. 5/5 rebase [-m]: calculate patches in upstream correctlyMartin von Zweigbergk, Jun 26, 2012
  7. Junio C HamanoJun 26, 2012
  8. Martin von ZweigbergkJun 27, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.