git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 8/9] git p4 test: cleanup_git should make a new $git

From
PWPete Wyckoff <pw@padd.com>
Date
Jun 26, 2012, 01:18 UTC
Message-ID
<1340673505-10551-9-git-send-email-pw@padd.com>
In-Reply-To
<1340673505-10551-1-git-send-email-pw@padd.com>

For convenience, leave one in place at the end of each test so that it is not necessary to build a new one. This makes it consistent with $cli.

Signed-off-by: Pete Wyckoff <pw@padd.com>
---
 t/lib-git-p4.sh           | 3 ++-
 t/t9800-git-p4-basic.sh   | 1 +
 t/t9806-git-p4-options.sh | 1 -
 3 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/t/lib-git-p4.sh b/t/lib-git-p4.sh
index 06d4d3a..15d2634 100644
--- a/t/lib-git-p4.sh
+++ b/t/lib-git-p4.sh
@@ -73,5 +73,6 @@ kill_p4d() {
 }
 
 cleanup_git() {
-	rm -rf "$git"
+	rm -rf "$git" &&
+	mkdir "$git"
 }
diff --git a/t/t9800-git-p4-basic.sh b/t/t9800-git-p4-basic.sh
index 60c1f57..234f727 100755
--- a/t/t9800-git-p4-basic.sh
+++ b/t/t9800-git-p4-basic.sh
@@ -270,6 +270,7 @@ test_expect_success 'wildcard files submit back to p4, delete' '
 '
 
 test_expect_success 'clone bare' '
+	rm -rf "$git" &&
 	git p4 clone --dest="$git" --bare //depot &&
 	test_when_finished cleanup_git &&
 	(
diff --git a/t/t9806-git-p4-options.sh b/t/t9806-git-p4-options.sh
index a37c6cb..fa40cc8 100755
--- a/t/t9806-git-p4-options.sh
+++ b/t/t9806-git-p4-options.sh
@@ -149,7 +149,6 @@ test_expect_success 'clone --use-client-spec' '
 	cleanup_git &&
 
 	# same thing again, this time with variable instead of option
-	mkdir "$git" &&
 	(
 		cd "$git" &&
 		git init &&
-- 
1.7.11.rc2.72.gebb7ee5
Previous: Pete WyckoffNext: Pete Wyckoff
Message 13 of 14 in “git p4 test fixes”
  1. 0/9 git p4 test fixesPete Wyckoff, Jun 26, 2012
  2. 1/9 git p4 test: wait longer for p4d to startPete Wyckoff, Jun 26, 2012
  3. Junio C HamanoJun 26, 2012
  4. 2/9 git p4 test: use real_path to resolve p4 client symlinksPete Wyckoff, Jun 26, 2012
  5. 3/9 git p4 test: simplify quoting involving TRASH_DIRECTORYPete Wyckoff, Jun 26, 2012
  6. Johannes SixtJun 26, 2012
  7. Junio C HamanoJun 26, 2012
  8. Pete WyckoffJun 26, 2012
  9. 4/9 git p4 test: never create default test repoPete Wyckoff, Jun 26, 2012
  10. 5/9 git p4 test: rename some "git-p4 command" stringsPete Wyckoff, Jun 26, 2012
  11. 6/9 git p4 test: check for error message in failed testPete Wyckoff, Jun 26, 2012
  12. 7/9 git p4 test: copy source indeterminatePete Wyckoff, Jun 26, 2012
  13. 8/9 git p4 test: cleanup_git should make a new $gitPete Wyckoff, Jun 26, 2012
  14. 9/9 git p4 test: split up big t9800 testPete Wyckoff, Jun 26, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.