git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH/RFC] Makefile: add missing GIT-VERSION-FILE dependency

From
Erik Faye-Lund <kusmabite@gmail.com>
Date
May 31, 2012, 14:10 UTC
Message-ID
<1338473444-8960-1-git-send-email-kusmabite@gmail.com>

In 20fc9bc (Set HTTP user agent to git/GIT_VERSION, 2006-04-04), http.o started recording GIT_VERSION, but http.o wasn't added to the list of files that depends on GIT-VERSION-FILE.

Fix this, so mofications to GIT-VERSION-FILE will result in an updated user-agent string.

Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
---

I stumbled over this while debugging something related. Perhaps this fix is worth applying?

There's a similar issue with generation of assembly-listings, but I figured that was intended for inspection of the generated code; the version string probably doesn't matter in such cases.

Dunno...
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index c09a679..59e2b25 100644
--- a/Makefile
+++ b/Makefile
@@ -2104,7 +2104,7 @@ configure: configure.ac
 	$(RM) $<+
 
 # These can record GIT_VERSION
-git.o git.spec \
+git.o git.spec http.o \
 	$(patsubst %.sh,%,$(SCRIPT_SH)) \
 	$(patsubst %.perl,%,$(SCRIPT_PERL)) \
 	: GIT-VERSION-FILE
-- 
1.7.11.rc0.6836.gdf573d9
Next: Junio C Hamano
Message 1 of 2 in “Makefile: add missing GIT-VERSION-FILE dependency”
  1. Makefile: add missing GIT-VERSION-FILE dependencyErik Faye-Lund, May 31, 2012
  2. Junio C HamanoMay 31, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.