git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv1 3/3] git p4: fix bug when enabling tag import/export via config variables

From
Luke Diamand <luke@diamand.org>
Date
May 11, 2012, 06:25 UTC
Message-ID
<1336717518-4214-4-git-send-email-luke@diamand.org>
In-Reply-To
<1336717518-4214-1-git-send-email-luke@diamand.org>

Use Python's True, not true. Causes failure when enabling tag import or export in "git p4" using a config option rather than the command line.

Signed-off-by: Luke Diamand <luke@diamand.org>
---
 git-p4.py |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/git-p4.py b/git-p4.py
index 8f0169a..f895a24 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -1451,7 +1451,7 @@ class P4Submit(Command, P4UserMap):
             rebase.rebase()
 
         if gitConfig("git-p4.exportLabels", "--bool") == "true":
-            self.exportLabels = true
+            self.exportLabels = True
 
         if self.exportLabels:
             p4Labels = getP4Labels(self.depotPath)
@@ -2711,7 +2711,7 @@ class P4Sync(Command, P4UserMap):
                         sys.stdout.write("\n")
 
         if gitConfig("git-p4.importLabels", "--bool") == "true":
-            self.importLabels = true
+            self.importLabels = True
 
         if self.importLabels:
             p4Labels = getP4Labels(self.depotPaths)
-- 
1.7.10.282.g2120.dirty
Previous: Luke DiamandNext: Pete Wyckoff
Message 4 of 5 in “[PATCHv1 0/3] git p4: tag import/export bug fixes”
  1. Luke DiamandMay 11, 2012
  2. 1/3 git p4: add test for tag import/export enabled via configLuke Diamand, May 11, 2012
  3. 2/3 git p4: fix bug when verbose enabled with tag exportLuke Diamand, May 11, 2012
  4. 3/3 git p4: fix bug when enabling tag import/export via config variablesLuke Diamand, May 11, 2012
  5. Pete WyckoffMay 11, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.