git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 1/9] streaming: void pointer instead of char pointer

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
May 3, 2012, 01:51 UTC
Message-ID
<1336009868-7411-2-git-send-email-pclouds@gmail.com>
In-Reply-To
<1336009868-7411-1-git-send-email-pclouds@gmail.com>
From: René Scharfe <rene.scharfe@lsrfire.ath.cx>

Allow any kind of buffer to be fed to read_istream() without an explicit cast by making it's buf argument a void pointer. It's about arbitrary data, not only characters.

Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 streaming.c |    2 +-
 streaming.h |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/streaming.c b/streaming.c
index 7e7ee2b..3a3cd12 100644
--- a/streaming.c
+++ b/streaming.c
@@ -99,7 +99,7 @@ int close_istream(struct git_istream *st)
 	return r;
 }
 
-ssize_t read_istream(struct git_istream *st, char *buf, size_t sz)
+ssize_t read_istream(struct git_istream *st, void *buf, size_t sz)
 {
 	return st->vtbl->read(st, buf, sz);
 }
diff --git a/streaming.h b/streaming.h
index 3e82770..1d05c2a 100644
--- a/streaming.h
+++ b/streaming.h
@@ -10,7 +10,7 @@ struct git_istream;
 
 extern struct git_istream *open_istream(const unsigned char *, enum object_type *, unsigned long *, struct stream_filter *);
 extern int close_istream(struct git_istream *);
-extern ssize_t read_istream(struct git_istream *, char *, size_t);
+extern ssize_t read_istream(struct git_istream *, void *, size_t);
 
 extern int stream_blob_to_fd(int fd, const unsigned char *, struct stream_filter *, int can_seek);
 
-- 
1.7.3.1.256.g2539c.dirty
Previous: Nguyễn Thái Ngọc DuyNext: Nguyễn Thái Ngọc Duy
Message 2 of 11 in “Large file support for git-archive”
  1. 0/9 Large file support for git-archiveNguyễn Thái Ngọc Duy, May 3, 2012
  2. 1/9 streaming: void pointer instead of char pointerNguyễn Thái Ngọc Duy, May 3, 2012
  3. 2/9 archive-tar: turn write_tar_entry into blob-writing onlyNguyễn Thái Ngọc Duy, May 3, 2012
  4. 3/9 archive-tar: unindent write_tar_entry by one levelNguyễn Thái Ngọc Duy, May 3, 2012
  5. 4/9 archive: delegate blob reading to backendNguyễn Thái Ngọc Duy, May 3, 2012
  6. 5/9 archive-tar: stream large blobs to tar fileNguyễn Thái Ngọc Duy, May 3, 2012
  7. 6/9 archive-zip: remove uncompressed_sizeNguyễn Thái Ngọc Duy, May 3, 2012
  8. 7/9 archive-zip: factor out helpers for writing sizes and CRCNguyễn Thái Ngọc Duy, May 3, 2012
  9. 8/9 archive-zip: streaming for stored filesNguyễn Thái Ngọc Duy, May 3, 2012
  10. 9/9 archive-zip: streaming for deflated filesNguyễn Thái Ngọc Duy, May 3, 2012
  11. 10/9 t5000: rationalize unzip testsRené Scharfe, May 3, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.