git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/5] diff: move TRANSLATORS comments so they're picked up

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Apr 30, 2012, 15:33 UTC
Message-ID
<1335799995-7667-2-git-send-email-avarab@gmail.com>
In-Reply-To
<1335799995-7667-1-git-send-email-avarab@gmail.com>

These TRANSLATORS comments weren't actually picked up by xgettext, the comment needs to be right before the Q_() function call, evidently it isn't picked up if that call is wrapped in another function call.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 diff.c |   16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/diff.c b/diff.c
index 7da16c9..5d06375 100644
--- a/diff.c
+++ b/diff.c
@@ -1413,22 +1413,22 @@ int print_stat_summary(FILE *fp, int files, int insertions, int deletions)
 	 * but nothing about added/removed lines? Is this a bug in Git?").
 	 */
 	if (insertions || deletions == 0) {
-		/*
-		 * TRANSLATORS: "+" in (+) is a line addition marker;
-		 * do not translate it.
-		 */
 		strbuf_addf(&sb,
+			    /*
+			     * TRANSLATORS: "+" in (+) is a line addition marker;
+			     * do not translate it.
+			     */
 			    Q_(", %d insertion(+)", ", %d insertions(+)",
 			       insertions),
 			    insertions);
 	}
 
 	if (deletions || insertions == 0) {
-		/*
-		 * TRANSLATORS: "-" in (-) is a line removal marker;
-		 * do not translate it.
-		 */
 		strbuf_addf(&sb,
+			    /*
+			     * TRANSLATORS: "-" in (-) is a line removal marker;
+			     * do not translate it.
+			     */
 			    Q_(", %d deletion(-)", ", %d deletions(-)",
 			       deletions),
 			    deletions);
-- 
1.7.10.546.gbaa1a.dirty
Previous: Ævar Arnfjörð BjarmasonNext: Junio C Hamano
Message 2 of 12 in “i18n: TRANSLATORS commends and LEGO--”
  1. 0/5 i18n: TRANSLATORS commends and LEGO--Ævar Arnfjörð Bjarmason, Apr 30, 2012
  2. 1/5 diff: move TRANSLATORS comments so they're picked upÆvar Arnfjörð Bjarmason, Apr 30, 2012
  3. Junio C HamanoApr 30, 2012
  4. Ævar Arnfjörð BjarmasonApr 30, 2012
  5. 2/5 i18n: Add more TRANSLATORS commentsÆvar Arnfjörð Bjarmason, Apr 30, 2012
  6. Junio C HamanoApr 30, 2012
  7. 3/5 git-branch: remove lego in i18n messagesÆvar Arnfjörð Bjarmason, Apr 30, 2012
  8. Junio C HamanoApr 30, 2012
  9. 4/5 git-commit: remove lego in i18n messagesÆvar Arnfjörð Bjarmason, Apr 30, 2012
  10. 5/5 git-commit: remove lego in i18n messagesÆvar Arnfjörð Bjarmason, Apr 30, 2012
  11. Junio C HamanoApr 30, 2012
  12. Ævar Arnfjörð BjarmasonApr 30, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.