git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git p4: fix unit tests

From
Luke Diamand <luke@diamand.org>
Date
Apr 25, 2012, 08:16 UTC
Message-ID
<1335341814-1598-2-git-send-email-luke@diamand.org>
In-Reply-To
<1335341814-1598-1-git-send-email-luke@diamand.org>

The submit-edit tests relied on P4EDITOR being unset. Set it explicitly to an empty string.

Signed-off-by: Luke Diamand <luke@diamand.org>
---
 t/t9805-git-p4-skip-submit-edit.sh |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t9805-git-p4-skip-submit-edit.sh b/t/t9805-git-p4-skip-submit-edit.sh
index 4a72f79..353dcfb 100755
--- a/t/t9805-git-p4-skip-submit-edit.sh
+++ b/t/t9805-git-p4-skip-submit-edit.sh
@@ -91,7 +91,7 @@ test_expect_success 'no config, edited' '
 		cd "$git" &&
 		echo line >>file1 &&
 		git commit -a -m "change 5" &&
-		EDITOR="\"$ed\"" git p4 submit &&
+		P4EDITOR="" EDITOR="\"$ed\"" git p4 submit &&
 		p4 changes //depot/... >wc &&
 		test_line_count = 5 wc
 	)
-- 
1.7.10.473.g0796
Previous: Luke DiamandNext: Junio C Hamano
Message 2 of 3 in “[PATCHv1] git p4: fix for submit/edit unit test”
  1. Luke DiamandApr 25, 2012
  2. git p4: fix unit testsLuke Diamand, Apr 25, 2012
  3. Junio C HamanoApr 25, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.