git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv4 2/5] git p4: Squash P4EDITOR in test harness

From
Luke Diamand <luke@diamand.org>
Date
Apr 24, 2012, 08:33 UTC
Message-ID
<1335256403-22162-3-git-send-email-luke@diamand.org>
In-Reply-To
<1335256403-22162-1-git-send-email-luke@diamand.org>

If P4EDITOR is set in the environment, test behavior could be unpredictable. Set it explicitly.

Signed-off-by: Luke Diamand <luke@diamand.org>
---
 t/lib-git-p4.sh |    1 +
 1 file changed, 1 insertion(+)
diff --git a/t/lib-git-p4.sh b/t/lib-git-p4.sh
index b90986c..121e380 100644
--- a/t/lib-git-p4.sh
+++ b/t/lib-git-p4.sh
@@ -24,6 +24,7 @@ P4DPORT=$((10669 + ($testid - $git_p4_test_start)))
 
 export P4PORT=localhost:$P4DPORT
 export P4CLIENT=client
+export P4EDITOR=:
 
 db="$TRASH_DIRECTORY/db"
 cli="$TRASH_DIRECTORY/cli"

-- 
1.7.10.8.g12781
Previous: Luke DiamandNext: Luke Diamand
Message 3 of 6 in “[PATCHv4 0/5] git p4: label import/export: documentation fix”
  1. Luke DiamandApr 24, 2012
  2. 1/5 git p4: Fixing script editor checksLuke Diamand, Apr 24, 2012
  3. 2/5 git p4: Squash P4EDITOR in test harnessLuke Diamand, Apr 24, 2012
  4. 3/5 git p4: Ignore P4EDITOR if it is emptyLuke Diamand, Apr 24, 2012
  5. 4/5 git p4: import/export of labels to/from p4Luke Diamand, Apr 24, 2012
  6. 5/5 git p4: move verbose to base classLuke Diamand, Apr 24, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.