git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v4 3/4] t4052: Test diff-stat output with minimum columns

From
Lucian Poston <lucian.poston@gmail.com>
Date
Apr 18, 2012, 02:29 UTC
Message-ID
<1334716196-9870-3-git-send-email-lucian.poston@gmail.com>
In-Reply-To
<1334716196-9870-1-git-send-email-lucian.poston@gmail.com>

When COLUMNS or --stat-width restricts the diff-stat width to near the minimum, 26 columns, the graph_width value becomes negative. Consequently, the graph part of diff-stat is not resized properly.

Signed-off-by: Lucian Poston <lucian.poston@gmail.com>
---
 t/t4052-stat-output.sh |   28 ++++++++++++++++++++++++++++
 1 files changed, 28 insertions(+), 0 deletions(-)
diff --git a/t/t4052-stat-output.sh b/t/t4052-stat-output.sh
index d748e5e..6305c99 100755
--- a/t/t4052-stat-output.sh
+++ b/t/t4052-stat-output.sh
@@ -284,6 +284,34 @@ respects expect200 show --stat
 respects expect200 log -1 --stat
 EOF
 
+cat >expect1 <<'EOF'
+ ...aaaaaaa | 1000 ++++++
+EOF
+cat >expect1-graph <<'EOF'
+|  ...aaaaaaa | 1000 ++++++
+EOF
+while read verb expect cmd args
+do
+	test_expect_failure "$cmd $verb prefix greater than COLUMNS (big change)" '
+		COLUMNS=1 git $cmd $args >output
+		grep " | " output >actual &&
+		test_cmp "$expect" actual
+	'
+
+	test "$cmd" != diff || continue
+
+	test_expect_failure "$cmd --graph $verb prefix greater than COLUMNS (big change)" '
+		COLUMNS=1 git $cmd $args --graph >output
+		grep " | " output >actual &&
+		test_cmp "$expect-graph" actual
+	'
+done <<\EOF
+ignores expect80 format-patch -1 --stdout
+respects expect1 diff HEAD^ HEAD --stat
+respects expect1 show --stat
+respects expect1 log -1 --stat
+EOF
+
 cat >expect <<'EOF'
  abcd | 1000 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 EOF
-- 
1.7.3.4
Previous: Lucian PostonNext: Junio C Hamano
Message 3 of 17 in “t4052: test --stat output with --graph”
  1. 1/4 t4052: test --stat output with --graphLucian Poston, Apr 18, 2012
  2. 2/4 Adjust stat width calculations to take --graph output into accountLucian Poston, Apr 18, 2012
  3. 3/4 t4052: Test diff-stat output with minimum columnsLucian Poston, Apr 18, 2012
  4. Junio C HamanoApr 18, 2012
  5. Lucian PostonApr 18, 2012
  6. Lucian PostonApr 18, 2012
  7. Kacper KornetApr 26, 2012
  8. test: skip test with COLUMNS=1 under mkshZbigniew Jędrzejewski-Szmek, Apr 27, 2012
  9. Junio C HamanoApr 27, 2012
  10. Zbigniew Jędrzejewski-SzmekApr 28, 2012
  11. Junio C HamanoApr 27, 2012
  12. Stefano LattariniApr 27, 2012
  13. Zbigniew Jędrzejewski-SzmekApr 28, 2012
  14. Junio C HamanoApr 29, 2012
  15. 4/4 Prevent graph_width of stat width from falling below minLucian Poston, Apr 18, 2012
  16. Lucian PostonApr 18, 2012
  17. Zbigniew Jędrzejewski-SzmekApr 18, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.