[PATCH 2/2] fix http auth with multiple curl handles
- From
Clemens Buchacher <drizzd@aon.at>
- Date
- Apr 10, 2012, 09:53 UTC
- Message-ID
- <1334051620-18044-3-git-send-email-drizzd@aon.at>
- In-Reply-To
- <1334051620-18044-1-git-send-email-drizzd@aon.at>
From: Jeff King <peff@peff.net>
HTTP authentication is currently handled by get_refs and fetch_ref, but not by fetch_object, fetch_pack or fetch_alternates. In the single-threaded case, this is not an issue, since get_refs is always called first. It recognigzes the 401 and prompts the user for credentials, which will then be used subsequently.
If the curl multi interface is used, however, only the multi handle used by get_refs will have credentials configured. Requests made by other handles fail with an authentication error.
Fix this by setting CURLOPT_USERPWD whenever a slot is requested.
Signed-off-by: Clemens Buchacher <drizzd@aon.at> --- http.c | 2 ++ t/t5550-http-fetch.sh | 10 +++++----- 2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/http.c b/http.c index f3f83d7..c6dc9b7 100644 --- a/http.c +++ b/http.c @@ -494,6 +494,8 @@ struct active_request_slot *get_active_slot(void) curl_easy_setopt(slot->curl, CURLOPT_POSTFIELDS, NULL); curl_easy_setopt(slot->curl, CURLOPT_UPLOAD, 0); curl_easy_setopt(slot->curl, CURLOPT_HTTPGET, 1); + if (http_auth.password) + init_curl_http_auth(slot->curl); return slot; } diff --git a/t/t5550-http-fetch.sh b/t/t5550-http-fetch.sh index 1d9ff1e..b06f817 100755 --- a/t/t5550-http-fetch.sh +++ b/t/t5550-http-fetch.sh @@ -92,21 +92,21 @@ test_expect_success 'http auth can use user/pass in URL' ' expect_askpass none ' -test_expect_failure 'http auth can use just user in URL' ' +test_expect_success 'http auth can use just user in URL' ' >askpass-query && echo user@host >askpass-response && git clone "$HTTPD_URL_USER/auth/repo.git" clone-auth-pass && expect_askpass pass user@host ' -test_expect_failure 'http auth can request both user and pass' ' +test_expect_success 'http auth can request both user and pass' ' >askpass-query && echo user@host >askpass-response && git clone "$HTTPD_URL/auth/repo.git" clone-auth-both && expect_askpass both user@host ' -test_expect_failure 'http auth respects credential helper config' ' +test_expect_success 'http auth respects credential helper config' ' test_config_global credential.helper "!f() { cat >/dev/null echo username=user@host @@ -118,7 +118,7 @@ test_expect_failure 'http auth respects credential helper config' ' expect_askpass none ' -test_expect_failure 'http auth can get username from config' ' +test_expect_success 'http auth can get username from config' ' test_config_global "credential.$HTTPD_URL.username" user@host && >askpass-query && echo user@host >askpass-response && @@ -126,7 +126,7 @@ test_expect_failure 'http auth can get username from config' ' expect_askpass pass user@host ' -test_expect_failure 'configured username does not override URL' ' +test_expect_success 'configured username does not override URL' ' test_config_global "credential.$HTTPD_URL.username" wrong && >askpass-query && echo user@host >askpass-response &&
-- 1.7.9.6