git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv1 1/2] git-p4: fix t9800 editor check

From
Luke Diamand <luke@diamand.org>
Date
Apr 3, 2012, 07:38 UTC
Message-ID
<1333438715-14902-2-git-send-email-luke@diamand.org>
In-Reply-To
<1333438715-14902-1-git-send-email-luke@diamand.org>

Use the skipEdit flag rather than the skipEditCheck flag as the latter only worked if P4EDITOR happened to be unset.

Signed-off-by: Luke Diamand <luke@diamand.org>
---
 t/t9800-git-p4-basic.sh |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t9800-git-p4-basic.sh b/t/t9800-git-p4-basic.sh
index 486c8ee..40f0b5c 100755
--- a/t/t9800-git-p4-basic.sh
+++ b/t/t9800-git-p4-basic.sh
@@ -335,7 +335,7 @@ test_expect_success 'detect renames' '
 	test_when_finished cleanup_git &&
 	(
 		cd "$git" &&
-		git config git-p4.skipSubmitEditCheck true &&
+		git config git-p4.skipSubmitEdit true &&
 
 		git mv file1 file4 &&
 		git commit -a -m "Rename file1 to file4" &&
@@ -394,7 +394,7 @@ test_expect_success 'detect copies' '
 	test_when_finished cleanup_git &&
 	(
 		cd "$git" &&
-		git config git-p4.skipSubmitEditCheck true &&
+		git config git-p4.skipSubmitEdit true &&
 
 		cp file2 file8 &&
 		git add file8 &&
-- 
1.7.10.rc0.158.gd9e55
Previous: Luke DiamandNext: Luke Diamand
Message 2 of 5 in “[PATCHv1] git-p4: label import, tag export”
  1. Luke DiamandApr 3, 2012
  2. 1/2 git-p4: fix t9800 editor checkLuke Diamand, Apr 3, 2012
  3. 2/2 git-p4: import/export of labels to/from p4Luke Diamand, Apr 3, 2012
  4. Vitor AntunesApr 3, 2012
  5. Luke DiamandApr 5, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.