git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/9 v6] difftool: remove explicit change of PATH

From
Tim Henigan <tim.henigan@gmail.com>
Date
Mar 22, 2012, 19:52 UTC
Message-ID
<1332445944-10944-5-git-send-email-tim.henigan@gmail.com>
In-Reply-To
<1332445944-10944-1-git-send-email-tim.henigan@gmail.com>

Adding the script directory to PATH is not needed. The script is located at '$(git --exec-path)', which is already on the PATH.

Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
---
 git-difftool.perl |    4 ----
 1 file changed, 4 deletions(-)
diff --git a/git-difftool.perl b/git-difftool.perl
index 33ae30a..77c9907 100755
--- a/git-difftool.perl
+++ b/git-difftool.perl
@@ -13,8 +13,6 @@
 use 5.008;
 use strict;
 use warnings;
-use Cwd qw(abs_path);
-use File::Basename qw(dirname);
 use Getopt::Long qw(:config pass_through);
 use Git;
 
@@ -33,8 +31,6 @@ USAGE
 
 sub setup_environment
 {
-	my $DIR = abs_path(dirname($0));
-	$ENV{PATH} = "$DIR:$ENV{PATH}";
 	$ENV{GIT_PAGER} = '';
 	$ENV{GIT_EXTERNAL_DIFF} = 'git-difftool--helper';
 }
-- 
1.7.10.rc1.36.g15e879
Previous: Tim HeniganNext: Tim Henigan
Message 5 of 10 in “difftool: teach command to perform directory diffs”
  1. 0/9 difftool: teach command to perform directory diffsTim Henigan, Mar 22, 2012
  2. 1/9 difftool: parse options using Getopt::LongTim Henigan, Mar 22, 2012
  3. 2/9 difftool: add '--no-gui' optionTim Henigan, Mar 22, 2012
  4. 3/9 difftool: exit(0) when usage is printedTim Henigan, Mar 22, 2012
  5. 4/9 difftool: remove explicit change of PATHTim Henigan, Mar 22, 2012
  6. 5/9 difftool: stop appending '.exe' to gitTim Henigan, Mar 22, 2012
  7. 6/9 difftool: eliminate setup_environment functionTim Henigan, Mar 22, 2012
  8. 7/9 difftool: replace system call with Git::command_noisyTim Henigan, Mar 22, 2012
  9. 8/9 difftool: teach difftool to handle directory diffsTim Henigan, Mar 22, 2012
  10. 9/9 difftool: print list of valid tools with '--tool-help'Tim Henigan, Mar 22, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.