git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 12/9 v5] t7800: add tests for difftool --dir-diff

From
Tim Henigan <tim.henigan@gmail.com>
Date
Mar 22, 2012, 15:02 UTC
Message-ID
<1332428541-24878-2-git-send-email-tim.henigan@gmail.com>
In-Reply-To
<1332428541-24878-1-git-send-email-tim.henigan@gmail.com>
Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
---
This replaces 12/9 in the previous version of the series.
Changes in v5:

Based on an example provided by David Aguilar on the Git developer list, the 'difftool --dir-diff from subdirectory' test is now wrapped in parentheses "()".

>From David's email:
> If we wrap the subdir operations in parentheses, then the sub-shell
> saves us from having to do "cd ..".  It also helps prevent leakage
> from earlier failures, which is helpful when writing new tests.
 t/t7800-difftool.sh |   39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)
diff --git a/t/t7800-difftool.sh b/t/t7800-difftool.sh
index 41d8399..5f3ad3f 100755
--- a/t/t7800-difftool.sh
+++ b/t/t7800-difftool.sh
@@ -311,4 +311,43 @@ test_expect_success PERL 'difftool --tool-help' '
 	echo "$tool_help" | stdin_contains tool
 '
 
+test_expect_success PERL 'setup change in subdirectory' '
+	git checkout master &&
+	mkdir sub &&
+	echo master >sub/sub &&
+	git add sub/sub &&
+	git commit -m "added sub/sub" &&
+	echo test >>file &&
+	echo test >>sub/sub &&
+	git add . &&
+	git commit -m "modified both"
+'
+
+test_expect_success PERL 'difftool -d' '
+	diff=$(git difftool -d --extcmd ls branch) &&
+	echo "$diff" | stdin_contains sub &&
+	echo "$diff" | stdin_contains file
+'
+
+test_expect_success PERL 'difftool --dir-diff' '
+	diff=$(git difftool --dir-diff --extcmd ls branch) &&
+	echo "$diff" | stdin_contains sub &&
+	echo "$diff" | stdin_contains file
+'
+
+test_expect_success PERL 'difftool --dir-diff ignores --prompt' '
+	diff=$(git difftool --dir-diff --prompt --extcmd ls branch) &&
+	echo "$diff" | stdin_contains sub &&
+	echo "$diff" | stdin_contains file
+'
+
+test_expect_success PERL 'difftool --dir-diff from subdirectory' '
+	(
+		cd sub &&
+		diff=$(git difftool --dir-diff --extcmd ls branch) &&
+		echo "$diff" | stdin_contains sub &&
+		echo "$diff" | stdin_contains file
+	)
+'
+
 test_done
-- 
1.7.10.rc1.40.g756bbcd
Previous: Tim HeniganNext: Tim Henigan
Message 2 of 3 in “difftool: fix regression in '--prompt' options”
  1. 10/9 difftool: fix regression in '--prompt' optionsTim Henigan, Mar 22, 2012
  2. 12/9 t7800: add tests for difftool --dir-diffTim Henigan, Mar 22, 2012
  3. 13/9 difftool: add '--no-gui' as an optionTim Henigan, Mar 22, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.