[PATCH 2/9] difftool: exit(0) when usage is printed
- From
Tim Henigan <tim.henigan@gmail.com>
- Date
- Mar 17, 2012, 01:57 UTC
- Message-ID
- <1331949442-15039-3-git-send-email-tim.henigan@gmail.com>
- In-Reply-To
- <1331949442-15039-1-git-send-email-tim.henigan@gmail.com>
Prior to this commit, the script exited with an error whenever the usage string was printed, regardless of the reason it was done. In cases where usage was printed due to a user request (e.g. '-h' option), the script should exit without error (exit 0).
This commit adds an argument to the usage function that allows the exit code to be specified when the function is called.
Signed-off-by: Tim Henigan <tim.henigan@gmail.com> --- git-difftool.perl | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/git-difftool.perl b/git-difftool.perl index e365727..81ecf34 100755 --- a/git-difftool.perl +++ b/git-difftool.perl @@ -20,12 +20,13 @@ use Git; sub usage { + my $exitcode = shift; print << 'USAGE'; usage: git difftool [-t|--tool=<tool>] [-x|--extcmd=<cmd>] [-y|--no-prompt] [-g|--gui] ['git diff' options] USAGE - exit 1; + exit($exitcode); } sub setup_environment @@ -56,14 +57,14 @@ GetOptions('g|gui' => \$gui, 'y|no-prompt' => \$no_prompt); if (defined($help)) { - usage(); + usage(0); } if (defined($difftool_cmd)) { if (length($difftool_cmd) > 0) { $ENV{GIT_DIFF_TOOL} = $difftool_cmd; } else { print "No <tool> given for --tool=<tool>\n"; - usage(); + usage(1); } } if (defined($extcmd)) { @@ -71,7 +72,7 @@ if (defined($extcmd)) { $ENV{GIT_DIFFTOOL_EXTCMD} = $extcmd; } else { print "No <cmd> given for --extcmd=<cmd>\n"; - usage(); + usage(1); } } if (defined($gui)) {
-- 1.7.9.1.290.gbd444