[PATCH 2/5 v2] contrib/diffall: create tmp dirs without mktemp
- From
Tim Henigan <tim.henigan@gmail.com>
- Date
- Mar 14, 2012, 16:38 UTC
- Message-ID
- <1331743086-32304-3-git-send-email-tim.henigan@gmail.com>
- In-Reply-To
- <1331743086-32304-1-git-send-email-tim.henigan@gmail.com>
mktemp is not available on all platforms. Instead of littering the code with a work-around, this commit replaces mktemp with a one-line Perl script.
Signed-off-by: Tim Henigan <tim.henigan@gmail.com> ---
v2 did not affect this patch.
contrib/diffall/git-diffall | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/contrib/diffall/git-diffall b/contrib/diffall/git-diffall index d706a6d..443f646 100755 --- a/contrib/diffall/git-diffall +++ b/contrib/diffall/git-diffall @@ -45,13 +45,10 @@ cd "$cdup" || { exit 1 } -# mktemp is not available on all platforms (missing from msysgit) -# Use a hard-coded tmp dir if it is not available -tmp="$(mktemp -d -t tmp.XXXXXX 2>/dev/null)" || { - tmp=/tmp/git-diffall-tmp.$$ - mkdir "$tmp" || exit 1 -} - +# set up temp dir +tmp=$(perl -e 'use File::Temp qw(tempdir); + $t=tempdir("/tmp/git-diffall.XXXXX") or exit(1); + print $t') || exit 1 trap 'rm -rf "$tmp" 2>/dev/null' EXIT left=
-- 1.7.10.rc0