git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/4] contrib/diffall: change comment to reflect actual reason for 'cdup'

From
Tim Henigan <tim.henigan@gmail.com>
Date
Mar 13, 2012, 17:45 UTC
Message-ID
<1331660734-10538-1-git-send-email-tim.henigan@gmail.com>

The comment from an earlier commit did not reflect the actual reason this operation is needed.

Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
---
 contrib/diffall/git-diffall |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/contrib/diffall/git-diffall b/contrib/diffall/git-diffall
index 9bbd27f..d706a6d 100755
--- a/contrib/diffall/git-diffall
+++ b/contrib/diffall/git-diffall
@@ -36,7 +36,9 @@ fi
 
 start_dir=$(pwd)
 
-# needed to access tar utility
+# All the file paths returned by the diff command are relative to the root
+# of the working copy. So if the script is called from a subdirectory, it
+# must switch to the root of working copy before trying to use those paths.
 cdup=$(git rev-parse --show-cdup) &&
 cd "$cdup" || {
 	echo >&2 "Cannot chdir to $cdup, the toplevel of the working tree"
-- 
1.7.10.rc0
Next: Tim Henigan
Message 1 of 5 in “contrib/diffall: change comment to reflect actual reason for 'cdup'”
  1. 1/4 contrib/diffall: change comment to reflect actual reason for 'cdup'Tim Henigan, Mar 13, 2012
  2. 2/4 contrib/diffall: teach diffall to create tmp dirs without using mktempTim Henigan, Mar 13, 2012
  3. 3/4 contrib/diffall: teach diffall to handle working copy changes without tarTim Henigan, Mar 13, 2012
  4. 4/4 contrib/diffall: eliminate duplicate while loopsTim Henigan, Mar 13, 2012
  5. Tim HeniganMar 13, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.