git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 6/7] fsck: use streaming API for writing lost-found blobs

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Mar 7, 2012, 10:54 UTC
Message-ID
<1331117661-19378-7-git-send-email-pclouds@gmail.com>
In-Reply-To
<1331117661-19378-1-git-send-email-pclouds@gmail.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 builtin/fsck.c |    8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/builtin/fsck.c b/builtin/fsck.c
index 67eb553..a710227 100644
--- a/builtin/fsck.c
+++ b/builtin/fsck.c
@@ -12,6 +12,7 @@
 #include "parse-options.h"
 #include "dir.h"
 #include "progress.h"
+#include "streaming.h"
 
 #define REACHABLE 0x0001
 #define SEEN      0x0002
@@ -238,13 +239,8 @@ static void check_unreachable_object(struct object *obj)
 			if (!(f = fopen(filename, "w")))
 				die_errno("Could not open '%s'", filename);
 			if (obj->type == OBJ_BLOB) {
-				enum object_type type;
-				unsigned long size;
-				char *buf = read_sha1_file(obj->sha1,
-						&type, &size);
-				if (buf && fwrite(buf, 1, size, f) != size)
+				if (stream_blob_to_fd(fileno(f), obj->sha1, NULL, 1))
 					die_errno("Could not write '%s'", filename);
-				free(buf);
 			} else
 				fprintf(f, "%s\n", sha1_to_hex(obj->sha1));
 			if (fclose(f))
-- 
1.7.8.36.g69ee2
Previous: Nguyễn Thái Ngọc DuyNext: Nguyễn Thái Ngọc Duy
Message 10 of 13 in “What's cooking in git.git (Mar 2012, #03; Mon, 5)”
  1. Junio C HamanoMar 6, 2012
  2. Nguyen Thai Ngoc DuyMar 6, 2012
  3. Junio C HamanoMar 6, 2012
  4. 0/7 nd/stream-more updatesNguyễn Thái Ngọc Duy, Mar 7, 2012
  5. 1/7 streaming: make streaming-write-entry to be more reusableNguyễn Thái Ngọc Duy, Mar 7, 2012
  6. 2/7 Add more large blob test casesNguyễn Thái Ngọc Duy, Mar 7, 2012
  7. 3/7 cat-file: use streaming API to print blobsNguyễn Thái Ngọc Duy, Mar 7, 2012
  8. 4/7 parse_object: avoid putting whole blob in coreNguyễn Thái Ngọc Duy, Mar 7, 2012
  9. 5/7 show: use streaming API for showing blobsNguyễn Thái Ngọc Duy, Mar 7, 2012
  10. 6/7 fsck: use streaming API for writing lost-found blobsNguyễn Thái Ngọc Duy, Mar 7, 2012
  11. 7/7 update-server-info: respect core.bigfilethresholdNguyễn Thái Ngọc Duy, Mar 7, 2012
  12. Junio C HamanoMar 7, 2012
  13. In preparation for 1.7.10-rc0Junio C Hamano, Mar 7, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.