git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH (bugfix)] gitweb: Fix passing parameters to git_project_search_form

From
Jakub Narebski <jnareb@gmail.com>
Date
Mar 2, 2012, 22:50 UTC
Message-ID
<1330728601-27124-1-git-send-email-jnareb@gmail.com>

The git_project_search_form() subroutine, introduced in a1e1b2d (gitweb: improve usability of projects search form, 2012-01-31) didn't get its arguments from caller correctly. Gitweb worked correctly thanks to sticky-ness of form fields in CGI.pm... but it make UTF-8 fix for project search not working.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
Brown paper bug (a1e1b2d is in master).  I am extremly sorry about that.
 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 7398be1..e2e6a73 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -5263,7 +5263,7 @@ sub git_patchset_body {
 # . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . .
 
 sub git_project_search_form {
-	my ($searchtext, $search_use_regexp);
+	my ($searchtext, $search_use_regexp) = @_;
 
 	my $limit = '';
 	if ($project_filter) {
-- 
1.7.9
Next: Junio C Hamano
Message 1 of 2 in “gitweb: Fix passing parameters to git_project_search_form”
  1. gitweb: Fix passing parameters to git_project_search_formJakub Narebski, Mar 2, 2012
  2. Junio C HamanoMar 2, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.