git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/4] index-pack improvements

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Feb 25, 2012, 10:56 UTC
Message-ID
<1330167376-24859-1-git-send-email-pclouds@gmail.com>

The first two patches are posted already, which help keep memory usage down in the present of large blobs. The forth patch attempts to resolve deltas in parallel.

$ time ./git index-pack --threads=1 --verify -v XXXX Indexing objects: 100% (165375/165375), done. Resolving deltas: 100% (124749/124749), done.

real 1m15.470s user 1m14.899s sys 0m0.552s

$ time ./git index-pack --threads=2 --verify -v XXXX Indexing objects: 100% (165375/165375), done. Resolving deltas: 100% (124749/124749), done.

real 0m41.339s user 1m15.116s sys 0m0.680s

$ time ./git index-pack --threads=3 --verify -v XXXX Indexing objects: 100% (165375/165375), done. Resolving deltas: 100% (124749/124749), done.

real 0m37.008s user 1m35.742s sys 0m0.803s

$ time ./git index-pack --verify -v XXXX # four core machine Indexing objects: 100% (165375/165375), done. Resolving deltas: 100% (124749/124749), done.

real 0m33.701s user 1m51.316s sys 0m0.768s

$ time ./git index-pack --threads=8 --verify -v XXXX Indexing objects: 100% (165375/165375), done. Resolving deltas: 100% (124749/124749), done.

real 0m33.638s user 1m51.783s sys 0m0.773s

So there's improvement from user persepective, but overhead is too high (user time from 1m14 to 1m51). Making threaded_second_pass to process 512 consecutive objects each iteration to reduce contention on work_mutex does not help. Any ideas?

Nguyễn Thái Ngọc Duy (4):
  index-pack --verify: skip sha-1 collision test
  index-pack: reduce memory usage when the pack has large blobs
  index-pack: move second pass code into separate function
  index-pack: support multithreaded delta resolving
 Documentation/config.txt         |    4 +
 Documentation/git-index-pack.txt |   10 ++
 Makefile                         |    2 +-
 builtin/index-pack.c             |  298 +++++++++++++++++++++++++++++++-------
 4 files changed, 260 insertions(+), 54 deletions(-)
-- 
1.7.8.36.g69ee2
Next: Nguyễn Thái Ngọc Duy
Message 1 of 5 in “index-pack improvements”
  1. 0/4 index-pack improvementsNguyễn Thái Ngọc Duy, Feb 25, 2012
  2. 1/4 index-pack --verify: skip sha-1 collision testNguyễn Thái Ngọc Duy, Feb 25, 2012
  3. 2/4 index-pack: reduce memory usage when the pack has large blobsNguyễn Thái Ngọc Duy, Feb 25, 2012
  4. 3/4 index-pack: move second pass code into separate functionNguyễn Thái Ngọc Duy, Feb 25, 2012
  5. 4/4 index-pack: support multithreaded delta resolvingNguyễn Thái Ngọc Duy, Feb 25, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.