[PATCH 2/2] CodingGuidelines: Add note forbidding use of 'which' in shell scripts

From: Tim Henigan <tim.henigan@gmail.com>
Date: Feb 24, 2012, 21:12 UTC
Message-ID: <1330117921-8257-2-git-send-email-tim.henigan@gmail.com>
In-Reply-To: <1330117921-8257-1-git-send-email-tim.henigan@gmail.com>

During the code review of a recent patch, it was noted that shell scripts must not use 'which'. The output of the command is not machine parseable and its exit code is not reliable across platforms.

Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
---
 Documentation/CodingGuidelines |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
index a4ffe7c..3505a4b 100644
--- a/Documentation/CodingGuidelines
+++ b/Documentation/CodingGuidelines
@@ -44,6 +44,10 @@ For shell scripts specifically (not exhaustive):
    properly nests.  It should have been the way Bourne spelled
    it from day one, but unfortunately isn't.
 
+ - The use of 'which' is not allowed.  The output of 'which' is not
+   machine parseable and its exit code is not reliable across
+   platforms.
+
  - We use POSIX compliant parameter substitutions and avoid bashisms;
    namely:

-- 
1.7.9.1