git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[RFC PATCH 0/3] git-p4: move to toplevel

From
PWPete Wyckoff <pw@padd.com>
Date
Feb 12, 2012, 18:13 UTC
Message-ID
<1329070423-23761-1-git-send-email-pw@padd.com>

The git-p4 code is in a single python script down in contrib/fast-import now. I'd like to move it up to the top-level source directory of git to make it easier to build and distribute. Git-p4 already takes advantage of the git infrastructure for documentation and testing, as well as the community support (Junio, many reviewers).

Users install git-p4 currently by copying the git-p4 script from contrib/fast-import into a local or personal bin directory, and setting up an alias for "git p4" to invoke it. If it is part of the install, the command will be available automatically. Also, distributions may be more likely to pick it up either as part of a core git package, or as a separate add-on. Getting support for python and git-p4 in msysgit is something I'd like to see happen too.

While I considered taking this opportunity to split up git-p4 into more modular components across multiple files, it seems best now just to do the script move intact. That effort could come later. If anyone has a strong preference to do this now, we could.

Developer note: Like all scripts in git, the source file is git-p4.py, which is built with "make" to git-p4, substituting the specified path for python in the first line. Be sure to edit the source file, and to build before running tests. This is sort of a pain for existing developers, but hopefully we can get used to it.

Pete Wyckoff (3):
  git-p4: move to toplevel
  git p4: update name in script
  git p4: use "git p4" directly in tests
 .gitignore                              |    1 +
 Documentation/git-p4.txt                |   23 +++------
 INSTALL                                 |    3 +
 Makefile                                |    1 +
 contrib/fast-import/git-p4.README       |   13 +++++
 contrib/fast-import/git-p4.bat          |    1 -
 contrib/fast-import/git-p4 => git-p4.py |   14 +++---
 t/lib-git-p4.sh                         |    8 +--
 t/t9800-git-p4-basic.sh                 |   84 +++++++++++++++---------------
 t/t9801-git-p4-branch.sh                |   32 ++++++------
 t/t9802-git-p4-filetype.sh              |   10 ++--
 t/t9803-git-p4-shell-metachars.sh       |   12 ++--
 t/t9804-git-p4-label.sh                 |    6 +-
 t/t9805-git-p4-skip-submit-edit.sh      |   22 ++++----
 t/t9806-git-p4-options.sh               |   28 +++++-----
 t/t9807-git-p4-submit.sh                |   22 ++++----
 t/t9808-git-p4-chdir.sh                 |    6 +-
 t/t9809-git-p4-client-view.sh           |   64 ++++++++++++------------
 18 files changed, 179 insertions(+), 171 deletions(-)
 create mode 100644 contrib/fast-import/git-p4.README
 delete mode 100644 contrib/fast-import/git-p4.bat
 rename contrib/fast-import/git-p4 => git-p4.py (99%)
-- 
1.7.9.192.ga1d4b
Next: Pete Wyckoff
Message 1 of 16 in “git-p4: move to toplevel”
  1. 0/3 git-p4: move to toplevelPete Wyckoff, Feb 12, 2012
  2. 1/3 git-p4: move to toplevelPete Wyckoff, Feb 12, 2012
  3. 2/3 git p4: update name in scriptPete Wyckoff, Feb 12, 2012
  4. 3/3 git p4: use "git p4" directly in testsPete Wyckoff, Feb 12, 2012
  5. Luke DiamandFeb 12, 2012
  6. Junio C HamanoFeb 13, 2012
  7. Pete WyckoffFeb 13, 2012
  8. Junio C HamanoFeb 13, 2012
  9. Clemens BuchacherFeb 13, 2012
  10. Junio C HamanoFeb 13, 2012
  11. Pete WyckoffFeb 13, 2012
  12. Clemens BuchacherFeb 14, 2012
  13. Junio C HamanoFeb 14, 2012
  14. Jeff KingFeb 14, 2012
  15. Junio C HamanoFeb 14, 2012
  16. Clemens BuchacherFeb 14, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.