git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] gitweb: Harden and improve $project_filter page title

From
Jakub Narebski <jnareb@gmail.com>
Date
Feb 12, 2012, 15:21 UTC
Message-ID
<1329060090-32370-1-git-send-email-jnareb@gmail.com>

Commit 19d2d23 (gitweb: add project_filter to limit project list to a subdirectory, 2012-01-30) added also support for displaying $project_filter, if present, in page title.

Unfortunately it forgot to treat $project_filter as path, and escape it using esc_path(), like it is done for $filename.

Also, it was not obvious that "$site_name - $project_filter" is about project filtering: use "$site_name - projects in '$project_filter'".

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
Though we should probably also esc_path($project), not only
to_utf8($project) in get_page_title() subroutine.

So I am not that sure if it is really necessary, or if I should follow it by further hardening of get_page_title().

Anyway I have noticed this when I was examining gitweb code for generating page title, considering adding information about search for project search. So this is patch I will be depending textually via context lines on.

 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 081ac45..8ba2022 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -3751,7 +3751,7 @@ sub get_page_title {
 
 	unless (defined $project) {
 		if (defined $project_filter) {
-			$title .= " - " . to_utf8($project_filter);
+			$title .= " - projects in '" . esc_path($project_filter) . "'";
 		}
 		return $title;
 	}
-- 
1.7.9
Message 1 of 1 in “gitweb: Harden and improve $project_filter page title”
  1. gitweb: Harden and improve $project_filter page titleJakub Narebski, Feb 12, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.