[RFC PATCH] gitweb: use CGI with -utf8
- From
Michał Kiedrowicz <michal.kiedrowicz@gmail.com>
- Date
- Feb 1, 2012, 22:50 UTC
- Message-ID
- <1328136653-20559-1-git-send-email-michal.kiedrowicz@gmail.com>
I noticed that gitweb tries a lot to properly process UTF-8 data, for example it prints my name correctly in log and commit information, but it echos junk in the search field. It looks like:
MichaÅ Kiedrowicz
I don't know CGI well and I never touched gitewb code, but I found this on http://www.lemoda.net/cgi/perl-unicode/index.html:
use CGI '-utf8';
my $value = params ('input');I tried it and that fixed my problem. I'm not sure about the consequences, maybe someone more experienced in CGI might help? --- gitweb/gitweb.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index abb5a79..74d45b1 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -10,7 +10,7 @@ use 5.008; use strict; use warnings; -use CGI qw(:standard :escapeHTML -nosticky); +use CGI qw(:standard :escapeHTML -nosticky -utf8); use CGI::Util qw(unescape); use CGI::Carp qw(fatalsToBrowser set_message); use Encode;
-- 1.7.3.4