Alternates corruption issue
- From
- Richard Purdie <richard.purdie@linuxfoundation.org>
- Date
- Jan 31, 2012, 14:05 UTC
- Message-ID
- <1328018729.13744.26.camel@ted>
I have a problem with git clone commands using alternates failing by mixing up different repositories. I have a situation where I could end up with both:
/srv/mirrors/repo /srv/mirrors/repo.git
as bare clones.
I then try cloning "repo" with alternates with the command:
$ git clone -s -n /srv/mirrors/repo /tmp/foo Cloning into /tmp/foo... done.
$ cat /tmp/foo/.git/objects/info/alternates /srv/mirrors/repo.git/objects
Note how I'm now referencing repo.git, not repo. This doesn't work as expected giving some very bizarre results when actually using the repository.
I appreciate this is a rather bizarre corner case but its one that is breaking the build system I work with. Ideally people would use a consistent URL for the same repository but we have an example where they haven't and this really shouldn't break like this.
Looking at the code, the cause seems to be
clone.c:get_repo_path():
static char *suffix[] = { "/.git", ".git", "" };since its looking in order for: repo/.git (fails) repo.git (suceeds, incorrect) repo (never looked at)
I'm not sure what would break if that order were to change, swapping the last two options.
I can "force" the issue by running:
git clone -s -n /srv/mirrors/repo/ /tmp/foo
but this results in the slightly odd looking:
$ cat /tmp/foo/.git/objects/info/alternates /srv/mirrors/repo//objects
which does at least work.
Any idea if its possible to fix the root cause of this problem?
Cheers,
Richard