[PATCH v3 3/3] git-p4: Change p4 command invocation

From: Vitor Antunes <vitor.hda@gmail.com>
Date: Jan 25, 2012, 23:48 UTC
Message-ID: <1327535304-11332-4-git-send-email-vitor.hda@gmail.com>
In-Reply-To: <1327535304-11332-1-git-send-email-vitor.hda@gmail.com>

From: Pete Wyckoff <pw@padd.com>

Change p4 command invocation to avoid going through the shell. This allows names with spaces and wildcards to work.

Signed-off-by: Pete Wyckoff <pw@padd.com>
Signed-off-by: Vitor Antunes <vitor.hda@gmail.com>
---
 contrib/fast-import/git-p4 |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
index 584cc41..74d3613 100755
--- a/contrib/fast-import/git-p4
+++ b/contrib/fast-import/git-p4
@@ -1975,7 +1975,7 @@ class P4Sync(Command, P4UserMap):
     def importChanges(self, changes):
         cnt = 1
         for change in changes:
-            description = p4Cmd("describe %s" % change)
+            description = p4Cmd(["describe", str(change)])
             self.updateOptionDict(description)
 
             if not self.silent:

-- 
1.7.8.3