git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/4] pack_refs(): remove redundant check

From
mhagger@alum.mit.edu <mhagger@alum.mit.edu>
Date
Jan 17, 2012, 05:50 UTC
Message-ID
<1326779434-20106-2-git-send-email-mhagger@alum.mit.edu>
In-Reply-To
<1326779434-20106-1-git-send-email-mhagger@alum.mit.edu>
From: Michael Haggerty <mhagger@alum.mit.edu>

handle_one_ref() only adds refs to the cbdata.ref_to_prune list if (cbdata.flags & PACK_REFS_PRUNE) is set. So any references in this list at the end of pack_refs() can be pruned unconditionally.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
Trivial simplification, not essential to the rest of this patch
series.
 pack-refs.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/pack-refs.c b/pack-refs.c
index 23bbd00..f09a054 100644
--- a/pack-refs.c
+++ b/pack-refs.c
@@ -143,7 +143,6 @@ int pack_refs(unsigned int flags)
 	packed.fd = -1;
 	if (commit_lock_file(&packed) < 0)
 		die_errno("unable to overwrite old ref-pack file");
-	if (cbdata.flags & PACK_REFS_PRUNE)
-		prune_refs(cbdata.ref_to_prune);
+	prune_refs(cbdata.ref_to_prune);
 	return 0;
 }
-- 
1.7.8.3
Previous: mhagger@alum.mit.eduNext: mhagger@alum.mit.edu
Message 2 of 7 in “Remove a user of extra_refs in clone”
  1. 0/4 Remove a user of extra_refs in clonemhagger@alum.mit.edu, Jan 17, 2012
  2. 1/4 pack_refs(): remove redundant checkmhagger@alum.mit.edu, Jan 17, 2012
  3. 2/4 ref_array: keep track of whether references are sortedmhagger@alum.mit.edu, Jan 17, 2012
  4. 3/4 add_packed_ref(): new function in the refs API.mhagger@alum.mit.edu, Jan 17, 2012
  5. 4/4 write_remote_refs(): create packed (rather than extra) refsmhagger@alum.mit.edu, Jan 17, 2012
  6. Jeff KingJan 17, 2012
  7. Junio C HamanoJan 17, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.