git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv3 0/4] git-p4: small fixes to branches and labels

From
Luke Diamand <luke@diamand.org>
Date
Jan 16, 2012, 23:14 UTC
Message-ID
<1326755689-3344-1-git-send-email-luke@diamand.org>

This is the third version of some small fixes to git-p4 branch and label handling.

It was suggested for the earlier version that the author handling could be simplified to use the 'author' variable. The code can be simplified, but the author is the wrong value to use - it is just the author of the commit, not the tag. Use the creator of the label, or, if that does not exist ("p4 tag ..."), the p4 user.

This change does not fix the other problems with git-p4 labels:
- two p4 labels on the same changelist will fall over
- labels must match exactly the list of files imported
- you can't import a label without a p4 commit
Luke Diamand (4):
  git-p4: handle p4 branches and labels containing shell chars
  git-p4: cope with labels with empty descriptions
  git-p4: importing labels should cope with missing owner
  git-p4: add test for p4 labels
 contrib/fast-import/git-p4        |   79 ++++++++++++++++++++----------------
 t/t9803-git-p4-shell-metachars.sh |   48 ++++++++++++++++++++++
 t/t9804-git-p4-label.sh           |   73 ++++++++++++++++++++++++++++++++++
 3 files changed, 165 insertions(+), 35 deletions(-)
 create mode 100755 t/t9804-git-p4-label.sh
-- 
1.7.8.rc1.209.geac91.dirty
Next: Luke Diamand
Message 1 of 7 in “[PATCHv3 0/4] git-p4: small fixes to branches and labels”
  1. Luke DiamandJan 16, 2012
  2. 1/4 git-p4: handle p4 branches and labels containing shell charsLuke Diamand, Jan 16, 2012
  3. Pete WyckoffJan 17, 2012
  4. Luke DiamandJan 19, 2012
  5. 2/4 git-p4: cope with labels with empty descriptionsLuke Diamand, Jan 16, 2012
  6. 3/4 git-p4: importing labels should cope with missing ownerLuke Diamand, Jan 16, 2012
  7. 4/4 git-p4: add test for p4 labelsLuke Diamand, Jan 16, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.