git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/5] git-p4: clarify comment

From
PWPete Wyckoff <pw@padd.com>
Date
Jan 11, 2012, 23:31 UTC
Message-ID
<1326324670-15967-4-git-send-email-pw@padd.com>
In-Reply-To
<1326324670-15967-1-git-send-email-pw@padd.com>
Signed-off-by: Pete Wyckoff <pw@padd.com>
---
 contrib/fast-import/git-p4 |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
index e267f31..e11e15b 100755
--- a/contrib/fast-import/git-p4
+++ b/contrib/fast-import/git-p4
@@ -1363,7 +1363,8 @@ class View(object):
             else:
                 # This mapping matched; no need to search any further.
                 # But, the mapping could be rejected if the client path
-                # has already been claimed by an earlier mapping.
+                # has already been claimed by an earlier mapping (i.e.
+                # one later in the list, which we are walking backwards).
                 already_mapped_in_client = False
                 for f in paths_filled:
                     # this is View.Path.match
-- 
1.7.8.1.409.g3e338.dirty
Previous: Pete WyckoffNext: Pete Wyckoff
Message 4 of 6 in “git-p4: view spec review fixes”
  1. 0/5 git-p4: view spec review fixesPete Wyckoff, Jan 11, 2012
  2. 1/5 git-p4: only a single ... wildcard is supportedPete Wyckoff, Jan 11, 2012
  3. 2/5 git-p4: fix verbose comment typoPete Wyckoff, Jan 11, 2012
  4. 3/5 git-p4: clarify commentPete Wyckoff, Jan 11, 2012
  5. 4/5 git-p4: adjust test to adhere to stricter useClientSpecPete Wyckoff, Jan 11, 2012
  6. 5/5 git-p4: add tests demonstrating spec overlay ambiguitiesPete Wyckoff, Jan 11, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.