git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Patches for message-digest support

From
BZBill Zaumen <bill.zaumen@gmail.com>
Date
Dec 21, 2011, 18:44 UTC
Message-ID
<1324493087.1761.23.camel@yos>

... sorry for an additional message. The patches I just sent were based on commit 876a6f4991abdd72ea707b193b4f2b831096ad3c (Update draft release notes to 1.7.9).

I should have also added that the function verify_commit was tested via a compile-time option, but it is currently not used. Its purpose is to verify that the (new) digest header in commit messages is consistent with the commit's tree, parents, other headers, and the commit message. For authentication, one would want to sign the commit SHA-1 hash and the message digest for the commit (which is stored separate from the commit object). My patch doesn't do that, but there is a single function that can be called to look up the digest, if one is present (which may not be the case due to backwards compatibility issues) - I'd prefer to have someone familiar with the signature code make any changes.

The version of Makefile in the patch turns off the commit message-digest header because some of the test scripts won't run with it, due to those encoding specific SHA-1 values and file lengths, but the test does run far enough to have created and used a number of commits. I didn't want to go to the trouble of updating the test scripts unless the patch is actually going to get used - updating the scripts is a bit tedious and you'd probably want to decide on the digest hash first.

Bill
Message 1 of 1 in “Re: Patches for message-digest support”
  1. Bill ZaumenDec 21, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.