git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/3] gitweb: Call to_utf8() on input string in chop_and_escape_str()

From
Jakub Narebski <jnareb@gmail.com>
Date
Dec 17, 2011, 09:15 UTC
Message-ID
<1324113324-21328-2-git-send-email-jnareb@gmail.com>
In-Reply-To
<1324113324-21328-1-git-send-email-jnareb@gmail.com>
From: Jürgen Kreileder <jk@blackdown.de>
a) To fix the comparison with the chopped string,
   otherwise we compare bytes with characters, as
   chop_str() must run to_utf8() for correct operation
b) To give the title attribute correct encoding;
   we need to mark strings as UTF-8 before outpur
Signed-off-by: Jürgen Kreileder <jk@blackdown.de>
Acked-by: Jakub Narębski <jnareb@gmail.com>
---
 gitweb/gitweb.perl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index f80f259..35126cd 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -1696,6 +1696,7 @@ sub chop_and_escape_str {
 	my ($str) = @_;
 
 	my $chopped = chop_str(@_);
+	$str = to_utf8($str);
 	if ($chopped eq $str) {
 		return esc_html($chopped);
 	} else {
-- 
1.7.6
Previous: Jakub NarebskiNext: Jakub Narebski
Message 2 of 4 in “gitweb: Various to_utf8 / esc_html fixes”
  1. 0/3 gitweb: Various to_utf8 / esc_html fixesJakub Narebski, Dec 17, 2011
  2. 1/3 gitweb: Call to_utf8() on input string in chop_and_escape_str()Jakub Narebski, Dec 17, 2011
  3. 2/3 gitweb: esc_html() site name for title in OPMLJakub Narebski, Dec 17, 2011
  4. 3/3 gitweb: Output valid utf8 in git_blame_common('data')Jakub Narebski, Dec 17, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.