git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/4] git-p4: ensure submit clientPath exists before chdir

From
PWPete Wyckoff <pw@padd.com>
Date
Dec 9, 2011, 23:48 UTC
Message-ID
<1323474497-14339-2-git-send-email-pw@padd.com>
In-Reply-To
<1323474497-14339-1-git-send-email-pw@padd.com>
From: Gary Gibbons <ggibbons@perforce.com>

Submitting patches back to p4 requires a p4 "client". This is a mapping from server depot paths into a local directory. The directory need not exist or be populated with files; only the mapping on the server is required. When there is no directory, make git-p4 automatically create it.

[ reword description --pw ]
Signed-off-by: Gary Gibbons <ggibbons@perforce.com>
Signed-off-by: Pete Wyckoff <pw@padd.com>
---
 contrib/fast-import/git-p4 |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
index b975d67..99d3abe 100755
--- a/contrib/fast-import/git-p4
+++ b/contrib/fast-import/git-p4
@@ -1099,6 +1099,10 @@ class P4Submit(Command, P4UserMap):
         print "Perforce checkout for depot path %s located at %s" % (self.depotPath, self.clientPath)
         self.oldWorkingDirectory = os.getcwd()
 
+        # ensure the clientPath exists
+        if not os.path.exists(self.clientPath):
+            os.makedirs(self.clientPath)
+
         chdir(self.clientPath)
         print "Synchronizing p4 checkout..."
         p4_sync("...")
-- 
1.7.8.rc4.42.g8317d
Previous: Pete WyckoffNext: Pete Wyckoff
Message 2 of 6 in “git-p4: paths for p4”
  1. 0/4 git-p4: paths for p4Pete Wyckoff, Dec 9, 2011
  2. 1/4 git-p4: ensure submit clientPath exists before chdirPete Wyckoff, Dec 9, 2011
  3. 2/4 git-p4: submit test for auto-creating clientPathPete Wyckoff, Dec 9, 2011
  4. 3/4 git-p4: use absolute directory for PWD env varPete Wyckoff, Dec 9, 2011
  5. 4/4 git-p4: test for absolute PWD problemPete Wyckoff, Dec 9, 2011
  6. Junio C HamanoDec 12, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.