git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-svn.perl: close the edit for propedits even with no mods

From
Steven Walter <stevenrwalter@gmail.com>
Date
Dec 1, 2011, 02:37 UTC
Message-ID
<1322707047-24227-1-git-send-email-stevenrwalter@gmail.com>

It's legitimate to update the mergeinfo property without actually changing any files. This can happen when changes are backported to a branch, and then that branch is merged back into mainline. We still want to record the updated mergeinfo for book-keeping.

Signed-off-by: Steven Walter <stevenrwalter@gmail.com>
---
 git-svn.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-svn.perl b/git-svn.perl
index 177dd25..cd64659 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -4867,7 +4867,7 @@ sub apply_diff {
 			               $self->{mergeinfo});
 	}
 	$self->rmdirs if $_rmdir;
-	if (@$mods == 0) {
+	if (@$mods == 0 && !defined($self->{mergeinfo})) {
 		$self->abort_edit;
 	} else {
 		$self->close_edit;
-- 
1.7.5.4
Next: Eric Wong
Message 1 of 3 in “git-svn.perl: close the edit for propedits even with no mods”
  1. git-svn.perl: close the edit for propedits even with no modsSteven Walter, Dec 1, 2011
  2. Eric WongDec 6, 2011
  3. Junio C HamanoDec 6, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.