git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/8] nd/resolve-ref v2

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Nov 17, 2011, 09:32 UTC
Message-ID
<1321522335-24193-1-git-send-email-pclouds@gmail.com>
The first part of actually nd/resolve-ref v2.

The last two patches are an attempt to catch overwriting faults in future. git_pathname() and resolve_ref_unsafe() are guarded.

(Un)fortunately I ran "make memcheck" but found no new segfaults. Either test coverage is insufficient, or we have done a very good job of reviewing/testing git.git

Nguyễn Thái Ngọc Duy (8):
  Convert many resolve_ref() calls to read_ref*() and ref_exists()
  Rename resolve_ref() to resolve_ref_unsafe()
  Re-add resolve_ref() that always returns an allocated buffer
  cmd_merge: convert to single exit point
  Use resolve_ref() instead of resolve_ref_unsafe()
  Convert resolve_ref_unsafe+xstrdup to resolve_ref
  Guard memory overwriting in resolve_ref_unsafe's static buffer
  Enable GIT_DEBUG_MEMCHECK on git_pathname()
 Makefile                |    3 ++
 branch.c                |    2 +-
 builtin/branch.c        |   11 +++----
 builtin/checkout.c      |   17 ++++++------
 builtin/commit.c        |    3 +-
 builtin/fmt-merge-msg.c |    8 ++++-
 builtin/for-each-ref.c  |    7 +---
 builtin/fsck.c          |    2 +-
 builtin/merge.c         |   56 +++++++++++++++++++++++++----------------
 builtin/notes.c         |    8 ++++-
 builtin/receive-pack.c  |    5 ++-
 builtin/remote.c        |   10 +++----
 builtin/replace.c       |    4 +-
 builtin/show-branch.c   |    6 +---
 builtin/show-ref.c      |    2 +-
 builtin/symbolic-ref.c  |    2 +-
 builtin/tag.c           |    4 +-
 bundle.c                |    2 +-
 cache.h                 |   17 +++++++++---
 git-compat-util.h       |    9 ++++++
 notes-merge.c           |    2 +-
 path.c                  |   28 ++++++++++++++------
 reflog-walk.c           |   13 +++++----
 refs.c                  |   63 +++++++++++++++++++++++++++++++---------------
 remote.c                |   10 +++---
 transport.c             |    2 +-
 wrapper.c               |   21 +++++++++++++++
 wt-status.c             |    4 +--
 28 files changed, 203 insertions(+), 118 deletions(-)
-- 
1.7.4.74.g639db
Next: Nguyễn Thái Ngọc Duy
Message 1 of 27 in “nd/resolve-ref v2”
  1. 0/8 nd/resolve-ref v2Nguyễn Thái Ngọc Duy, Nov 17, 2011
  2. 1/8 Convert many resolve_ref() calls to read_ref*() and ref_exists()Nguyễn Thái Ngọc Duy, Nov 17, 2011
  3. 2/8 Rename resolve_ref() to resolve_ref_unsafe()Nguyễn Thái Ngọc Duy, Nov 17, 2011
  4. 3/8 Re-add resolve_ref() that always returns an allocated bufferNguyễn Thái Ngọc Duy, Nov 17, 2011
  5. 4/8 cmd_merge: convert to single exit pointNguyễn Thái Ngọc Duy, Nov 17, 2011
  6. Ramkumar RamachandraNov 17, 2011
  7. Jonathan NiederNov 17, 2011
  8. 5/8 Use resolve_ref() instead of resolve_ref_unsafe()Nguyễn Thái Ngọc Duy, Nov 17, 2011
  9. 6/8 Convert resolve_ref_unsafe+xstrdup to resolve_refNguyễn Thái Ngọc Duy, Nov 17, 2011
  10. Ramkumar RamachandraNov 17, 2011
  11. Nguyen Thai Ngoc DuyNov 18, 2011
  12. 7/8 Guard memory overwriting in resolve_ref_unsafe's static bufferNguyễn Thái Ngọc Duy, Nov 17, 2011
  13. 8/8 Enable GIT_DEBUG_MEMCHECK on git_pathname()Nguyễn Thái Ngọc Duy, Nov 17, 2011
  14. Ramkumar RamachandraNov 17, 2011
  15. Jeff KingNov 17, 2011
  16. Nguyen Thai Ngoc DuyNov 18, 2011
  17. Jeff KingNov 18, 2011
  18. Jonathan NiederNov 18, 2011
  19. Nguyen Thai Ngoc DuyNov 18, 2011
  20. Jeff KingNov 18, 2011
  21. Jonathan NiederNov 18, 2011
  22. Johan HerlandNov 18, 2011
  23. Jonathan NiederNov 18, 2011
  24. Junio C HamanoNov 18, 2011
  25. Bernhard R. LinkNov 18, 2011
  26. Jonathan NiederNov 17, 2011
  27. Nguyen Thai Ngoc DuyDec 6, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.