git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 1/4] fsck: return error code when verify_pack() goes wrong

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Nov 7, 2011, 02:59 UTC
Message-ID
<1320634766-24511-2-git-send-email-pclouds@gmail.com>
In-Reply-To
<1320634766-24511-1-git-send-email-pclouds@gmail.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 builtin/fsck.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/builtin/fsck.c b/builtin/fsck.c
index df1a88b..4ead98d 100644
--- a/builtin/fsck.c
+++ b/builtin/fsck.c
@@ -29,6 +29,7 @@ static int write_lost_and_found;
 static int verbose;
 #define ERROR_OBJECT 01
 #define ERROR_REACHABLE 02
+#define ERROR_PACK 04
 
 #ifdef NO_D_INO_IN_DIRENT
 #define SORT_DIRENT 0
@@ -626,7 +627,8 @@ int cmd_fsck(int argc, const char **argv, const char *prefix)
 		prepare_packed_git();
 		for (p = packed_git; p; p = p->next)
 			/* verify gives error messages itself */
-			verify_pack(p);
+			if (verify_pack(p))
+				errors_found |= ERROR_PACK;
 
 		for (p = packed_git; p; p = p->next) {
 			uint32_t j, num;
-- 
1.7.4.74.g639db
Previous: Nguyễn Thái Ngọc DuyNext: Nguyễn Thái Ngọc Duy
Message 2 of 6 in “fsck improvements”
  1. 0/4 fsck improvementsNguyễn Thái Ngọc Duy, Nov 7, 2011
  2. 1/4 fsck: return error code when verify_pack() goes wrongNguyễn Thái Ngọc Duy, Nov 7, 2011
  3. 2/4 verify_packfile(): check as many object as possible in a packNguyễn Thái Ngọc Duy, Nov 7, 2011
  4. 3/4 fsck: avoid reading every object twiceNguyễn Thái Ngọc Duy, Nov 7, 2011
  5. 4/4 fsck: print progressNguyễn Thái Ngọc Duy, Nov 7, 2011
  6. Junio C HamanoNov 7, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.