git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Escape file:// URL's to meet subversion SVN::Ra requirements

From
Ben Walton <bwalton@artsci.utoronto.ca>
Date
Nov 2, 2011, 19:05 UTC
Message-ID
<1320260449-sup-479@pinkfloyd.chass.utoronto.ca>
In-Reply-To
<20111102182015.GA11401@elie.hsd1.il.comcast.net>
Excerpts from Jonathan Nieder's message of Wed Nov 02 14:20:38 -0400 2011:
Show 6 quoted lines
> Thanks for your work on this!  I'm not really sure how one can
> decide that the problem is not in svn --- some existing functions
> changed ABI in such a way as to break existing applications and
> require code changes and a recompile.  It would be better for
> Subversion to silently fix up paths provided by bad callers, or at
> least to return a sensible error code.

Yes, my apologies. I wrote this commit message before fully realizing just how wrong the response on the svn list was. It core dumps, after all...If the patch is useful, I'll resubmit with a better commit message.

Show 11 quoted lines
> So the problem is that nobody who cared was testing prereleases of
> subversion and reporting bugs early enough for it to get this fixed
> before the 1.7 release.  But yes, that's water under the bridge and
> git-svn (and libsvn-perl, and pysvn, and ...) should just adjust to
> the new world order.
> 
> > [1] http://news.gmane.org/gmane.comp.version-control.subversion.devel
> 
> Do you mean
> http://thread.gmane.org/gmane.comp.version-control.subversion.devel/132250
> ?

No, the link should have been: http://article.gmane.org/gmane.comp.version-control.subversion.devel/132227

I'm not sure how it got mangled like that.
Show 6 quoted lines
> | # failed 1 among 2 test(s)
> | 1..2
> | make[3]: *** [t9145-git-svn-master-branch.sh] Error 1
> 
> Does it work for you?  This is with a merge of git 1.7.8-rc0 and
> 1.7.7.2.

Yikes...I had svn tests turned off in my global build script still and only validated this against t9134. My apologies. I'll submit something proper later this evening. (Assuming I get a working patch that passes the whole suite.)

Sorry for the clumsy patch.

Thanks -Ben

-- Ben Walton Systems Programmer - CHASS University of Toronto C:416.407.5610 | W:416.978.4302

Previous: Jonathan NiederNext: Eric Wong
Message 4 of 11 in “(unknown)”
  1. Ben WaltonNov 2, 2011
  2. Escape file:// URL's to meet subversion SVN::Ra requirementsBen Walton, Nov 2, 2011
  3. Jonathan NiederNov 2, 2011
  4. Ben WaltonNov 2, 2011
  5. Eric WongNov 2, 2011
  6. Ben WaltonNov 4, 2011
  7. Jonathan NiederNov 4, 2011
  8. Michael WittenJul 16, 2012
  9. Jonathan NiederDec 17, 2011
  10. Jonathan NiederDec 17, 2011
  11. Ben WaltonDec 17, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.